fix: check for duplicate proprerties

Author: wojtek-krysiak

src/features/upload-file/factories/strip-payload-factory.spec.ts

@@ -53,5 +53,31 @@ describe('stripPayloadFactory', () => {
         [uploadOptions.properties.filesToDelete]: payload[uploadOptions.properties.filesToDelete],
       })
     })
+
+    it('throws error when user wants to use the same properties twice', async () => {
+      try {
+        await stripPayload({ payload, method: 'post' } as ActionRequest, actionContext)
+      } catch (error) {
+        expect(error).not.to.be.undefined
+        return undefined
+      }
+      throw new Error()
+    })
+
+    it('fills context with invocations for each run', async () => {
+      uploadOptions = {
+        ...uploadOptions,
+        properties: {
+          key: 's3Key2',
+          filePath: 'resolvedPath2',
+          file: 'file2',
+          filesToDelete: 'fileToDelete2',
+        },
+      }
+      stripPayload = stripPayloadFactory(uploadOptions)
+      await stripPayload({ payload, method: 'post' } as ActionRequest, actionContext)
+
+      expect(actionContext[CONTEXT_NAMESPACE].__invocations).to.have.lengthOf(2)
+    })
   })
 })

src/features/upload-file/factories/strip-payload-factory.ts

@@ -11,6 +11,11 @@ type ContextNamespace = {
    * `file` can be `myFile`
    */
   [key: string]: any,
+  /**
+   * When we strip payload for each upload we are also storing use properties under __invocations
+   * key. This is because in the next step we have to validate if all the properties are unique.
+   * Otherwise upload from one element will override the upload in another element.
+   */
   __invocations: Array<FeatureInvocation>
 }
 
@@ -30,7 +35,8 @@ export const stripPayloadFactory = (
         ...data,
         [properties.file]: flat.get(request.payload, properties.file),
         [properties.filesToDelete]: flat.get(request.payload, properties.filesToDelete),
-        __invocations: data.__invocations || [
+        __invocations: [
+          ...(data.__invocations || []),
           { properties },
         ],
       }

src/features/upload-file/utils/validate-properties.ts

@@ -37,7 +37,7 @@ export const hasDuplicatedProperties = (
 }
 
 /**
- * Checks if all properties
+ * Checks if all properties have uniq names
  */
 export const validatePropertiesGlobally = (
   globalContext: Array<FeatureInvocation>,