Skip to content

Commit df21fac

Browse files
committed
fix(ci): correct artifact paths in build-smol workflow
Fixed bootstrap artifact upload/download paths to preserve directory structure. Issue: Artifacts uploaded as 'packages/bootstrap/dist/' were being stripped to 'bootstrap/dist/' when downloaded, causing MODULE_NOT_FOUND errors during smol binary build. Solution: - Upload entire packages/ directory to preserve structure - Download directly to packages/ directory - Simplified verification (no manual moving needed) This ensures build script can find bootstrap at expected path: packages/bootstrap/dist/bootstrap-smol.js Also updated .gitignore to exclude all .claude/ directories (not just root).
1 parent d89b68e commit df21fac

File tree

3 files changed

+8
-243
lines changed

3 files changed

+8
-243
lines changed

.github/workflows/build-smol.yml

Lines changed: 7 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -78,9 +78,7 @@ jobs:
7878
uses: actions/upload-artifact@50769540e7f4bd5e21e526ee35c689e35e0d6874 # v4.4.0
7979
with:
8080
name: build-deps-smol-${{ github.sha }}
81-
path: |
82-
packages/bootstrap/dist/
83-
packages/socket/dist/
81+
path: packages/
8482
retention-days: 1
8583

8684
build-smol:
@@ -131,35 +129,18 @@ jobs:
131129
uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
132130
with:
133131
name: build-deps-smol-${{ github.sha }}
134-
path: .
132+
path: packages/
135133

136134
- name: Verify bootstrap artifacts
137135
shell: bash
138136
run: |
139137
echo "=== Verifying downloaded bootstrap artifacts ==="
140-
echo "Directory structure after download:"
141-
find bootstrap socket -type f -name "*.js" 2>/dev/null || echo "No JS files found in bootstrap/socket at root"
142-
find packages/bootstrap packages/socket -type f -name "*.js" 2>/dev/null || echo "No JS files found in packages/"
143-
144138
echo ""
145-
echo "Looking for bootstrap-smol.js:"
146-
ls -lh bootstrap/dist/bootstrap-smol.js 2>/dev/null && echo "Found at: bootstrap/dist/bootstrap-smol.js" || echo "Not at: bootstrap/dist/"
147-
ls -lh packages/bootstrap/dist/bootstrap-smol.js 2>/dev/null && echo "Found at: packages/bootstrap/dist/bootstrap-smol.js" || echo "Not at: packages/bootstrap/dist/"
148-
149-
# Check both possible locations
150-
if [ -f bootstrap/dist/bootstrap-smol.js ]; then
151-
echo "✓ Bootstrap found at root level, moving to packages/"
152-
mkdir -p packages/bootstrap/dist packages/socket/dist
153-
mv bootstrap/dist/* packages/bootstrap/dist/ 2>/dev/null || true
154-
mv socket/dist/* packages/socket/dist/ 2>/dev/null || true
155-
elif [ -f packages/bootstrap/dist/bootstrap-smol.js ]; then
156-
echo "✓ Bootstrap already in correct location"
157-
else
158-
echo "❌ ERROR: bootstrap-smol.js not found in any expected location!"
159-
exit 1
160-
fi
161-
162-
echo "✓ Bootstrap artifacts verified and in correct location"
139+
echo "Checking for required files:"
140+
ls -lh packages/bootstrap/dist/bootstrap-smol.js && echo "✓ bootstrap-smol.js present" || (echo "❌ bootstrap-smol.js missing" && exit 1)
141+
ls -lh packages/socket/dist/bootstrap.js && echo "✓ socket bootstrap.js present" || (echo "❌ socket bootstrap.js missing" && exit 1)
142+
echo ""
143+
echo "✓ Bootstrap artifacts verified"
163144
164145
- name: Setup Node.js
165146
uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0

.gitignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
.DS_Store
22
._.DS_Store
33
Thumbs.db
4-
/.claude
4+
.claude/
55
/.node-source
66
/.node-source-test
77
/.scratch

packages/cli/.claude/test-failure-analysis.md

Lines changed: 0 additions & 216 deletions
This file was deleted.

0 commit comments

Comments
 (0)