Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create GUI for signing the XML file #166

Open
bitcoinwarrior1 opened this issue May 21, 2019 · 3 comments
Open

Create GUI for signing the XML file #166

bitcoinwarrior1 opened this issue May 21, 2019 · 3 comments
Assignees

Comments

@bitcoinwarrior1
Copy link
Contributor

bitcoinwarrior1 commented May 21, 2019

Currently, Makefile serves 3 functions.

  1. Validate the XML file against the schema.
  2. If invalid, use xmllint to highlight the problem. xmllint only works with canonicalized version thanks to the lack of support of entitty references.
  3. If valid, sign it.

All should be done in one tool.

@hboon
Copy link
Member

hboon commented May 22, 2019

How about a cli instead?

It's easier to add commands to it to do things like validation and lower effort to build. Easier for users to integrate into their processes/tools too.

Or is this specifically for XML signing only (with key management etc) by design? Which makes sense too.

@bitcoinwarrior1
Copy link
Contributor Author

@hboon this is supposed to be for the case that you don't have make installed, i.e. if you use windows. I am wondering if it is simply easier to just install Make if you don't have it, what do you think @colourful-land?

@SmartLayer
Copy link

SmartLayer commented May 22, 2019

@hboon is suggesting a commandline tool to replace Makefile. Makefile is what we can get with shortest development time. Now, we need something that signs like xmlsectool and debugs like xmllint, which doesn't exist yet (but more or less satisfied with Makefile). In the short future, we need something that can link up Ethereum to show if a TokenScript is trusted, that's the time we can't continue Makefile any more (or by Makfile itself any more).

We need to build the cli tool before building the GUI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants