WWSTCERT-8745 Add shelly wave door-window driver #2460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Steven Green <[email protected]>
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Invitation URL: |
Test Results 71 files 465 suites 0s ⏱️ Results for commit cdcc09d. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against cdcc09d |
greens
changed the title
wkhenon
reviewed
Nov 6, 2025
| productType: 0x0100 | ||
| productId: 0x0081 | ||
| deviceProfileName: shelly-wave-door-window-sensor | ||
|
|
greens
reviewed
Nov 11, 2025
Comment on lines
+32
to
+39
| local function can_handle_wave_door_window_sensor(opts, driver, device, ...) | ||
| for _, fingerprint in ipairs(WAVE_DOOR_WINDOW_SENSOR_FINGERPRINTS) do | ||
| if device:id_match(fingerprint.manufacturerId, fingerprint.productType, fingerprint.productId) then | ||
| return true | ||
| end | ||
| end | ||
| return false | ||
| end |
Contributor
There was a problem hiding this comment.
For our drivers that use lazy_load_if_possible the return values of the can_handle function need to be a little different.
For an example: https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/blob/main/drivers/SmartThings/zwave-sensor/src/sensative-strip/init.lua#L29
greens
reviewed
Nov 11, 2025
| if cmd.args.sensor_type == SensorMultilevel.sensor_type.LUMINANCE then | ||
| device:emit_event(capabilities.illuminanceMeasurement.illuminance({value = cmd.args.sensor_value, unit = "lux"})) | ||
| elseif cmd.args.sensor_type == SensorMultilevel.sensor_type.DIRECTION then | ||
| device:emit_event(capabilities.relativeHumidityMeasurement.humidity({value = cmd.args.sensor_value, unit = "%"})) |
greens
reviewed
Nov 11, 2025
| if cmd.args.sensor_type == SensorMultilevel.sensor_type.LUMINANCE then | ||
| device:emit_event(capabilities.illuminanceMeasurement.illuminance({value = cmd.args.sensor_value, unit = "lux"})) | ||
| elseif cmd.args.sensor_type == SensorMultilevel.sensor_type.DIRECTION then | ||
| device:emit_event(capabilities.relativeHumidityMeasurement.humidity({value = cmd.args.sensor_value, unit = "%"})) |
Contributor
There was a problem hiding this comment.
The profile you've specified doesn't include relativeHumidityMeasurement. This event will never be seen with the current profile. It should either be removed, which means you can just use the default handling, or you need to add relativeHumidityMeasurement to your profile.
greens
reviewed
Nov 11, 2025
Contributor
greens
left a comment
greens
left a comment
There was a problem hiding this comment.
Please include unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check all that apply
Type of Change
Checklist
Description of Change
Summary of Completed Tests