AssertSameDifferentTypesRule is obsolete

Author: ondrejmirtes

README.md

@@ -13,10 +13,8 @@ This extension provides following features:
 * `getMock()` called on `MockBuilder` is also supported.
 * Interprets `Foo|PHPUnit_Framework_MockObject_MockObject` in phpDoc so that it results in an intersection type instead of a union type.
 * Defines early terminating method calls for the `PHPUnit\Framework\TestCase` class to prevent undefined variable errors.
-
-It also contains this framework-specific rule (can be enabled separately):
-
-* Check that both values passed to `assertSame()` method are of the same type.
+* Specifies types of expressions passed to various `assert` methods like `assertInstanceOf`, `assertTrue`, `assertInternalType` etc.
+* Combined with PHPStan's level 4, it points out always-true and always-false asserts like `assertTrue(true)` etc.
 
 It also contains this strict framework-specific rules (can be enabled separately):
 
@@ -88,9 +86,3 @@ To perform framework-specific checks, include also this file:
 ```
 	- vendor/phpstan/phpstan-phpunit/rules.neon
 ```
-
-To perform addition strict PHPUnit checks, include also this file:
-
-```
-	- vendor/phpstan/phpstan-phpunit/strictRules.neon
-```

phpstan.neon

@@ -1,7 +1,6 @@
 includes:
 	- extension.neon
 	- rules.neon
-	- strictRules.neon
 	- vendor/phpstan/phpstan-strict-rules/rules.neon
 
 parameters:

rules.neon

@@ -1,2 +1,4 @@
 rules:
-	- PHPStan\Rules\PHPUnit\AssertSameDifferentTypesRule
+	- PHPStan\Rules\PHPUnit\AssertSameBooleanExpectedRule
+	- PHPStan\Rules\PHPUnit\AssertSameNullExpectedRule
+	- PHPStan\Rules\PHPUnit\AssertSameWithCountRule

src/Rules/PHPUnit/AssertSameDifferentTypesRule.php

@@ -0,0 +1,85 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Rules\PHPUnit;
+
+use PHPStan\Rules\Comparison\ImpossibleCheckTypeMethodCallRule;
+use PHPStan\Rules\Rule;
+use PHPStan\Type\PHPUnit\Assert\AssertMethodTypeSpecifyingExtension;
+
+class AssertSameMethodDifferentTypesRuleTest extends \PHPStan\Testing\RuleTestCase
+{
+
+	protected function getRule(): Rule
+	{
+		return new ImpossibleCheckTypeMethodCallRule(true);
+	}
+
+	/**
+	 * @return \PHPStan\Type\MethodTypeSpecifyingExtension[]
+	 */
+	protected function getMethodTypeSpecifyingExtensions(): array
+	{
+		return [
+			new AssertMethodTypeSpecifyingExtension(),
+		];
+	}
+
+	public function testRule(): void
+	{
+		$this->analyse([__DIR__ . '/data/assert-same.php'], [
+			[
+				'Call to method PHPUnit\Framework\Assert::assertSame() will always evaluate to false.',
+				10,
+			],
+			[
+				'Call to method PHPUnit\Framework\Assert::assertSame() will always evaluate to false.',
+				11,
+			],
+			[
+				'Call to method PHPUnit\Framework\Assert::assertSame() will always evaluate to false.',
+				12,
+			],
+			[
+				'Call to method PHPUnit\Framework\Assert::assertSame() will always evaluate to false.',
+				13,
+			],
+			[
+				'Call to method PHPUnit\Framework\Assert::assertSame() will always evaluate to false.',
+				14,
+			],
+			[
+				'Call to method PHPUnit\Framework\Assert::assertSame() will always evaluate to false.',
+				39,
+			],
+			[
+				'Call to method PHPUnit\Framework\Assert::assertSame() will always evaluate to true.',
+				44,
+			],
+			[
+				'Call to method PHPUnit\Framework\Assert::assertSame() will always evaluate to false.',
+				45,
+			],
+			[
+				'Call to method PHPUnit\Framework\Assert::assertSame() will always evaluate to true.',
+				46,
+			],
+			[
+				'Call to method PHPUnit\Framework\Assert::assertSame() will always evaluate to false.',
+				47,
+			],
+			[
+				'Call to method PHPUnit\Framework\Assert::assertSame() will always evaluate to true.',
+				48,
+			],
+			[
+				'Call to method PHPUnit\Framework\Assert::assertSame() will always evaluate to false.',
+				51,
+			],
+			[
+				'Call to method PHPUnit\Framework\Assert::assertSame() will always evaluate to false.',
+				52,
+			],
+		]);
+	}
+
+}

strictRules.neon

@@ -0,0 +1,57 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Rules\PHPUnit;
+
+use PHPStan\Rules\Comparison\ImpossibleCheckTypeStaticMethodCallRule;
+use PHPStan\Rules\Rule;
+use PHPStan\Type\PHPUnit\Assert\AssertStaticMethodTypeSpecifyingExtension;
+
+class AssertSameStaticMethodDifferentTypesRuleTest extends \PHPStan\Testing\RuleTestCase
+{
+
+	protected function getRule(): Rule
+	{
+		return new ImpossibleCheckTypeStaticMethodCallRule(true);
+	}
+
+	/**
+	 * @return \PHPStan\Type\StaticMethodTypeSpecifyingExtension[]
+	 */
+	protected function getStaticMethodTypeSpecifyingExtensions(): array
+	{
+		return [
+			new AssertStaticMethodTypeSpecifyingExtension(),
+		];
+	}
+
+	public function testRule(): void
+	{
+		$this->analyse([__DIR__ . '/data/assert-same.php'], [
+			[
+				'Call to static method PHPUnit\Framework\Assert::assertSame() will always evaluate to false.',
+				16,
+			],
+			[
+				'Call to static method PHPUnit\Framework\Assert::assertSame() will always evaluate to false.',
+				17,
+			],
+			[
+				'Call to static method PHPUnit\Framework\Assert::assertSame() will always evaluate to false.',
+				18,
+			],
+			[
+				'Call to static method PHPUnit\Framework\Assert::assertSame() will always evaluate to false.',
+				53,
+			],
+			[
+				'Call to static method PHPUnit\Framework\Assert::assertSame() will always evaluate to false.',
+				54,
+			],
+			[
+				'Call to static method PHPUnit\Framework\Assert::assertSame() will always evaluate to false.',
+				55,
+			],
+		]);
+	}
+
+}