You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Scheduling tasks with the Scheduler outside of the Render Thread should hard fail with an exception otherwise it could introduce hard to debug CMEs if a task is scheduled while the scheduler is being ticked. Currently to my knowledge only the API authentication does off-thread task scheduling.
Additionally scheduling a null task should fail with an NPE and the Preconditions class should be used to ensure tasks aren't being scheduled in the past and whatnot.
The migration path for any off-thread scheduling is just to wrap it in a client#send call like so: client.send(() -> Scheduler.INSTANCE.schedule(...)).
These changes will decrease the likelihood of the Scheduler being used improperly.
Images
No response
The text was updated successfully, but these errors were encountered:
Describe the new feature.
Scheduling tasks with the
Scheduler
outside of the Render Thread should hard fail with an exception otherwise it could introduce hard to debug CMEs if a task is scheduled while the scheduler is being ticked. Currently to my knowledge only the API authentication does off-thread task scheduling.Additionally scheduling a null task should fail with an NPE and the
Preconditions
class should be used to ensure tasks aren't being scheduled in the past and whatnot.The migration path for any off-thread scheduling is just to wrap it in a
client#send
call like so:client.send(() -> Scheduler.INSTANCE.schedule(...))
.These changes will decrease the likelihood of the Scheduler being used improperly.
Images
No response
The text was updated successfully, but these errors were encountered: