Skip to content

Commit 7724fd7

Browse files
authoredNov 23, 2022
Polish oracle plugin to make DBType accurate (#32)
1 parent 2038b54 commit 7724fd7

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed
 

‎oracle-10.x-plugin/src/main/java/io/skywalking/apm/plugin/jdbc/oracle/PreparedStatementExecuteMethodsInterceptor.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ public final void beforeMethod(EnhancedInstance objInst, Method method, Object[]
5050
if (cacheObject != null && cacheObject.getConnectionInfo() != null) {
5151
ConnectionInfo connectInfo = cacheObject.getConnectionInfo();
5252
AbstractSpan span = ContextManager.createExitSpan(buildOperationName(connectInfo, method.getName(), cacheObject.getStatementName()), connectInfo.getDatabasePeer());
53-
Tags.DB_TYPE.set(span, "sql");
53+
Tags.DB_TYPE.set(span, connectInfo.getDBType());
5454
Tags.DB_INSTANCE.set(span, connectInfo.getDatabaseName());
5555
Tags.DB_STATEMENT.set(span, cacheObject.getSql());
5656
span.setComponent(connectInfo.getComponent());

‎oracle-10.x-plugin/src/main/java/io/skywalking/apm/plugin/jdbc/oracle/StatementExecuteMethodsInterceptor.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public void beforeMethod(EnhancedInstance objInst, Method method, Object[] allAr
3838
ConnectionInfo connectInfo = cacheObject.getConnectionInfo();
3939

4040
AbstractSpan span = ContextManager.createExitSpan(buildOperationName(connectInfo, method.getName(), cacheObject.getStatementName()), connectInfo.getDatabasePeer());
41-
Tags.DB_TYPE.set(span, "sql");
41+
Tags.DB_TYPE.set(span, connectInfo.getDBType());
4242
Tags.DB_INSTANCE.set(span, connectInfo.getDatabaseName());
4343

4444
String sql = "";

0 commit comments

Comments
 (0)