lagging server Legacy Material Support

[qindesik]

Skript/Server Version

[01:58:14 INFO]: [Skript] Skript's aliases can be found here: https://github.com/SkriptLang/skript-aliases
[01:58:14 INFO]: [Skript] Skript's documentation can be found here: https://docs.skriptlang.org/
[01:58:14 INFO]: [Skript] Skript's tutorials can be found here: https://docs.skriptlang.org/tutorials
[01:58:14 INFO]: [Skript] Server Version: 1.21-2284-4e55e26 (MC: 1.21)
[01:58:14 INFO]: [Skript] Skript Version: 2.10.0 (skriptlang-github)
[01:58:14 INFO]: [Skript] Installed Skript Addons: None
[01:58:14 INFO]: [Skript] Installed dependencies: None

Bug Description

server simply lags or crashes

Expected Behavior

.

Steps to Reproduce

idk

Errors or Screenshots

[19:59:33] [Server thread/WARN]: [org.bukkit.craftbukkit.legacy.CraftLegacy] Initializing Legacy Material Support. Unless you have legacy plugins and/or data this is a bug!
[19:59:43] [Watchdog Thread/ERROR]: --- DO NOT REPORT THIS TO PURPUR - THIS IS NOT A BUG OR A CRASH - 1.21-2284-4e55e26 (MC: 1.21) ---
[19:59:43] [Watchdog Thread/ERROR]: The server has not responded for 10 seconds! Creating thread dump
[19:59:43] [Watchdog Thread/ERROR]: ------------------------------
[19:59:43] [Watchdog Thread/ERROR]: Server thread dump (Look for plugins here before reporting to Purpur!):
[19:59:43] [Watchdog Thread/ERROR]: Ticking entity: minecraft:player, entity class: net.minecraft.server.level.ServerPlayer
[19:59:43] [Watchdog Thread/ERROR]: Entity status: removed: false, valid: true, alive: true, is passenger: false
[19:59:43] [Watchdog Thread/ERROR]: Entity UUID: c79521c4-eaae-37f0-b3ad-b36731ef0a72
[19:59:43] [Watchdog Thread/ERROR]: Position: world: 'world' at location (-1239.2716298578948, 81.43717636799826, 1441.4847018352596)
[19:59:43] [Watchdog Thread/ERROR]: Velocity: (0.0, -1.0225815514780583, 0.0) (in blocks per tick)
[19:59:43] [Watchdog Thread/ERROR]: Entity AABB: AABB[-1239.5716298698158, 81.43717636799826, 1441.1847018233386] -> [-1238.971629845974, 82.93717636799826, 1441.7847018471805]
[19:59:43] [Watchdog Thread/ERROR]: Total packets processed on the main thread for all players: 32803
[19:59:43] [Watchdog Thread/ERROR]: ------------------------------
[19:59:43] [Watchdog Thread/ERROR]: Current Thread: Server thread
[19:59:43] [Watchdog Thread/ERROR]: PID: 103 | Suspended: false | Native: false | State: RUNNABLE
[19:59:43] [Watchdog Thread/ERROR]: Stack:
[19:59:43] [Watchdog Thread/ERROR]: com.mojang.datafixers.functions.Fold.cap(Fold.java:78)
[19:59:43] [Watchdog Thread/ERROR]: com.mojang.datafixers.functions.Fold.lambda$eval$2(Fold.java:90)
[19:59:43] [Watchdog Thread/ERROR]: com.mojang.datafixers.functions.Fold$$Lambda/0x00007f69793ae090.apply(Unknown Source)
[19:59:43] [Watchdog Thread/ERROR]: com.mojang.datafixers.functions.Comp.applyUnchecked(Comp.java:126)
[19:59:43] [Watchdog Thread/ERROR]: com.mojang.datafixers.functions.Comp.lambda$eval$2(Comp.java:118)
[19:59:43] [Watchdog Thread/ERROR]: com.mojang.datafixers.functions.Comp$$Lambda/0x00007f69793a24f8.apply(Unknown Source)
[19:59:43] [Watchdog Thread/ERROR]: com.mojang.datafixers.types.Type.capWrite(Type.java:167)
[19:59:43] [Watchdog Thread/ERROR]: com.mojang.datafixers.types.Type.lambda$readAndWrite$10(Type.java:159)
[19:59:43] [Watchdog Thread/ERROR]: com.mojang.datafixers.types.Type$$Lambda/0x00007f69793a2078.apply(Unknown Source)
[19:59:43] [Watchdog Thread/ERROR]: com.mojang.serialization.DataResult$Success.flatMap(DataResult.java:201)
[19:59:43] [Watchdog Thread/ERROR]: com.mojang.datafixers.types.Type.readAndWrite(Type.java:158)
[19:59:43] [Watchdog Thread/ERROR]: com.mojang.datafixers.DataFixerUpper.update(DataFixerUpper.java:78)
[19:59:43] [Watchdog Thread/ERROR]: org.bukkit.craftbukkit.legacy.CraftLegacy.(CraftLegacy.java:412)
[19:59:43] [Watchdog Thread/ERROR]: org.bukkit.craftbukkit.util.CraftMagicNumbers.getBlock(CraftMagicNumbers.java:123)
[19:59:43] [Watchdog Thread/ERROR]: org.bukkit.craftbukkit.block.CraftBlockState.setRawData(CraftBlockState.java:269)
[19:59:43] [Watchdog Thread/ERROR]: Skript-2.10.0.jar//ch.njol.skript.classes.data.BukkitEventValues.lambda$static$30(BukkitEventValues.java:282)
[19:59:43] [Watchdog Thread/ERROR]: Skript-2.10.0.jar//ch.njol.skript.classes.data.BukkitEventValues$$Lambda/0x00007f6978a1d3d0.convert(Unknown Source)
[19:59:43] [Watchdog Thread/ERROR]: Skript-2.10.0.jar//ch.njol.skript.expressions.base.EventValueExpression.getValue(EventValueExpression.java:207)
[19:59:43] [Watchdog Thread/ERROR]: Skript-2.10.0.jar//ch.njol.skript.expressions.base.EventValueExpression.get(EventValueExpression.java:188)
[19:59:43] [Watchdog Thread/ERROR]: Skript-2.10.0.jar//ch.njol.skript.lang.util.SimpleExpression.getArray(SimpleExpression.java:78)
[19:59:43] [Watchdog Thread/ERROR]: Skript-2.10.0.jar//ch.njol.skript.lang.util.ConvertedExpression.getArray(ConvertedExpression.java:177)
[19:59:43] [Watchdog Thread/ERROR]: Skript-2.10.0.jar//ch.njol.skript.expressions.base.PropertyExpression.get(PropertyExpression.java:171)
[19:59:43] [Watchdog Thread/ERROR]: Skript-2.10.0.jar//ch.njol.skript.lang.util.SimpleExpression.getArray(SimpleExpression.java:78)
[19:59:43] [Watchdog Thread/ERROR]: Skript-2.10.0.jar//ch.njol.skript.expressions.base.PropertyExpression.get(PropertyExpression.java:171)
[19:59:43] [Watchdog Thread/ERROR]: Skript-2.10.0.jar//ch.njol.skript.lang.util.SimpleExpression.check(SimpleExpression.java:136)
[19:59:43] [Watchdog Thread/ERROR]: Skript-2.10.0.jar//ch.njol.skript.conditions.CondCompare.check(CondCompare.java:334)
[19:59:43] [Watchdog Thread/ERROR]: Skript-2.10.0.jar//ch.njol.skript.lang.Condition.evaluate(Condition.java:78)
[19:59:43] [Watchdog Thread/ERROR]: Skript-2.10.0.jar//ch.njol.skript.lang.Condition.evaluate(Condition.java:23)
[19:59:43] [Watchdog Thread/ERROR]: Skript-2.10.0.jar//org.skriptlang.skript.lang.condition.Conditional.evaluate(Conditional.java:45)
[19:59:43] [Watchdog Thread/ERROR]: Skript-2.10.0.jar//org.skriptlang.skript.lang.condition.Conditional.evaluateAnd(Conditional.java:105)
[19:59:43] [Watchdog Thread/ERROR]: Skript-2.10.0.jar//org.skriptlang.skript.lang.condition.CompoundConditional.evaluate(CompoundConditional.java:85)
[19:59:43] [Watchdog Thread/ERROR]: Skript-2.10.0.jar//org.skriptlang.skript.lang.condition.CompoundConditional.evaluate(CompoundConditional.java:68)
[19:59:43] [Watchdog Thread/ERROR]: Skript-2.10.0.jar//ch.njol.skript.sections.SecConditional.checkConditions(SecConditional.java:400)
[19:59:43] [Watchdog Thread/ERROR]: Skript-2.10.0.jar//ch.njol.skript.sections.SecConditional.walk(SecConditional.java:288)
[19:59:43] [Watchdog Thread/ERROR]: Skript-2.10.0.jar//ch.njol.skript.lang.TriggerItem.walk(TriggerItem.java:67)
[19:59:43] [Watchdog Thread/ERROR]: Skript-2.10.0.jar//ch.njol.skript.lang.Trigger.execute(Trigger.java:33)
[19:59:43] [Watchdog Thread/ERROR]: Skript-2.10.0.jar//ch.njol.skript.SkriptEventHandler.lambda$execute$2(SkriptEventHandler.java:165)
[19:59:43] [Watchdog Thread/ERROR]: Skript-2.10.0.jar//ch.njol.skript.SkriptEventHandler$$Lambda/0x00007f6978e0b360.run(Unknown Source)
[19:59:43] [Watchdog Thread/ERROR]: Skript-2.10.0.jar//ch.njol.skript.SkriptEventHandler.lambda$execute$3(SkriptEventHandler.java:176)
[19:59:43] [Watchdog Thread/ERROR]: Skript-2.10.0.jar//ch.njol.skript.SkriptEventHandler$$Lambda/0x00007f6978e0b580.call(Unknown Source)
[19:59:43] [Watchdog Thread/ERROR]: Skript-2.10.0.jar//ch.njol.skript.util.Task.callSync(Task.java:147)
[19:59:43] [Watchdog Thread/ERROR]: Skript-2.10.0.jar//ch.njol.skript.util.Task.callSync(Task.java:131)
[19:59:43] [Watchdog Thread/ERROR]: Skript-2.10.0.jar//ch.njol.skript.SkriptEventHandler.execute(SkriptEventHandler.java:174)
[19:59:43] [Watchdog Thread/ERROR]: Skript-2.10.0.jar//ch.njol.skript.SkriptEventHandler.check(SkriptEventHandler.java:120)
[19:59:43] [Watchdog Thread/ERROR]: Skript-2.10.0.jar//ch.njol.skript.SkriptEventHandler$PriorityListener.lambda$new$0(SkriptEventHandler.java:46)
[19:59:43] [Watchdog Thread/ERROR]: Skript-2.10.0.jar//ch.njol.skript.SkriptEventHandler$PriorityListener$$Lambda/0x00007f6978ddad70.execute(Unknown Source)
[19:59:43] [Watchdog Thread/ERROR]: co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:80)
[19:59:43] [Watchdog Thread/ERROR]: org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70)
[19:59:43] [Watchdog Thread/ERROR]: io.papermc.paper.plugin.manager.PaperEventManager.callEvent(PaperEventManager.java:54)
[19:59:43] [Watchdog Thread/ERROR]: io.papermc.paper.plugin.manager.PaperPluginManagerImpl.callEvent(PaperPluginManagerImpl.java:131)
[19:59:43] [Watchdog Thread/ERROR]: org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:628)
[19:59:43] [Watchdog Thread/ERROR]: org.bukkit.craftbukkit.event.CraftEventFactory.getPlayerBucketEvent(CraftEventFactory.java:537)
[19:59:43] [Watchdog Thread/ERROR]: org.bukkit.craftbukkit.event.CraftEventFactory.callPlayerBucketEmptyEvent(CraftEventFactory.java:509)
[19:59:43] [Watchdog Thread/ERROR]: net.minecraft.world.item.BucketItem.emptyContents(BucketItem.java:188)
[19:59:43] [Watchdog Thread/ERROR]: net.minecraft.world.item.BucketItem.use(BucketItem.java:110)
[19:59:43] [Watchdog Thread/ERROR]: net.minecraft.world.item.ItemStack.use(ItemStack.java:605)
[19:59:43] [Watchdog Thread/ERROR]: net.minecraft.server.level.ServerPlayerGameMode.useItem(ServerPlayerGameMode.java:489)
[19:59:43] [Watchdog Thread/ERROR]: net.minecraft.server.network.ServerGamePacketListenerImpl.handleUseItem(ServerGamePacketListenerImpl.java:2040)
[19:59:43] [Watchdog Thread/ERROR]: net.minecraft.network.protocol.game.ServerboundUseItemPacket.handle(ServerboundUseItemPacket.java:47)
[19:59:43] [Watchdog Thread/ERROR]: net.minecraft.network.protocol.game.ServerboundUseItemPacket.handle(ServerboundUseItemPacket.java:10)
[19:59:43] [Watchdog Thread/ERROR]: net.minecraft.network.protocol.PacketUtils.lambda$ensureRunningOnSameThread$0(PacketUtils.java:56)
[19:59:43] [Watchdog Thread/ERROR]: net.minecraft.network.protocol.PacketUtils$$Lambda/0x00007f69790850d0.run(Unknown Source)
[19:59:43] [Watchdog Thread/ERROR]: net.minecraft.server.TickTask.run(TickTask.java:18)
[19:59:43] [Watchdog Thread/ERROR]: net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:151)
[19:59:43] [Watchdog Thread/ERROR]: net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:24)
[19:59:43] [Watchdog Thread/ERROR]: net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:1573)
[19:59:43] [Watchdog Thread/ERROR]: net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:201)
[19:59:43] [Watchdog Thread/ERROR]: net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:125)
[19:59:43] [Watchdog Thread/ERROR]: net.minecraft.server.MinecraftServer.pollTaskInternal(MinecraftServer.java:1550)
[19:59:43] [Watchdog Thread/ERROR]: net.minecraft.server.MinecraftServer.pollTask(MinecraftServer.java:1543)
[19:59:43] [Watchdog Thread/ERROR]: net.minecraft.util.thread.BlockableEventLoop.managedBlock(BlockableEventLoop.java:135)
[19:59:43] [Watchdog Thread/ERROR]: net.minecraft.server.MinecraftServer.managedBlock(MinecraftServer.java:1502)
[19:59:43] [Watchdog Thread/ERROR]: net.minecraft.server.MinecraftServer.waitUntilNextTick(MinecraftServer.java:1509)
[19:59:43] [Watchdog Thread/ERROR]: net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1354)
[19:59:43] [Watchdog Thread/ERROR]: net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:333)
[19:59:43] [Watchdog Thread/ERROR]: net.minecraft.server.MinecraftServer$$Lambda/0x00007f6977c73418.run(Unknown Source)
[19:59:43] [Watchdog Thread/ERROR]: [email protected]/java.lang.Thread.runWith(Thread.java:1596)
[19:59:43] [Watchdog Thread/ERROR]: [email protected]/java.lang.Thread.run(Thread.java:1583)

Other

No response

Agreement

• I have read the guidelines above and affirm I am following them with this report.

[sovdeeth]

This isn't technically a bug, but we could look into removing the need for setRawData in the bucket events.

I believe there's also interest in removing the future values entirely since they're not reliable.

[qindesik]

This isn't technically a bug, but we could look into removing the need for setRawData in the bucket events.

I believe there's also interest in removing the future values entirely since they're not reliable.

Is there any way I can fix the lags and crashes?

[sovdeeth]

Initialize legacy support when your server starts up. It will only occur once per server restart.

[qindesik]

Initialize legacy support when your server starts up. It will only occur once per server restart.

Do you have a tutorial on how to fix this or could you explain it to me more?

[sovdeeth]

You could not use the bucket fill/empty events or you could use reflect to do something like dandelion.getData().getType() or some other method that uses the legacy materials.
On just trigger a bucket fill/empty event when your server starts up.

[ShaneBeee]

I am curious tho, Skript being 1.19.x+, why is it still using legacy methods?

[sovdeeth]

I am curious tho, Skript being 1.19.x+, why is it still using legacy methods?

Simply because no one's bothered to update/remove it.