Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wind charge projectile is fireball #7491

Closed
1 task done
Envqu opened this issue Jan 20, 2025 · 2 comments
Closed
1 task done

Wind charge projectile is fireball #7491

Envqu opened this issue Jan 20, 2025 · 2 comments
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update.

Comments

@Envqu
Copy link

Envqu commented Jan 20, 2025

Skript/Server Version

[22:13:57 INFO]: [Skript] Server Version: 1.21.3-2358-16ce24a (MC: 1.21.3)
[22:13:57 INFO]: [Skript] Skript Version: 2.10.0 (skriptlang-github)
[22:13:57 INFO]: [Skript] Installed Skript Addons: 
[22:13:57 INFO]: [Skript]  - ItemsAdder v4.0.7-beta-9 (devs.beer)
[22:13:57 INFO]: [Skript]  - skript-db v1.3.9
[22:13:57 INFO]: [Skript]  - skript-placeholders v1.7.0 (https://github.com/APickledWalrus/skript-placeholders)
[22:13:57 INFO]: [Skript]  - skript-itemsadder v1.6.1
[22:13:57 INFO]: [Skript]  - SkBee v3.8.1 (https://github.com/ShaneBeee/SkBee)
[22:13:57 INFO]: [Skript] Installed dependencies: 
[22:13:57 INFO]: [Skript]  - Vault v1.7.3-b131
[22:13:57 INFO]: [Skript]  - WorldGuard v7.0.13-beta-1+2f13ae0

Bug Description

Wind charge projectile is fireball.
Cant kill wind charge projectile or cancel event

Expected Behavior

Make wind charge wind charge

Steps to Reproduce

on projectile hit:
	if projectile is an wind charge or fireball:
		broadcast "%event-projectile%"
		kill projectile
		cancel event

Errors or Screenshots

No response

Other

No response

Agreement

  • I have read the guidelines above and affirm I am following them with this report.
@ShaneBeee
Copy link
Contributor

Skript's EntityData system is such a mess.
(Ive worked on this many times, and god I hate it)
I really wish Skript would get rid of it.

The whole system either needs a major re-write, or a complete deletion.

@Fusezion
Copy link
Contributor

There's a few related issues for this but the issue itself is caused by priority being non existent within entity data classes.
Since WindCharge, WitherSkull and many other projectiles extend the AbstractFireball stuff skript refuses to listen to it.

@sovdeeth sovdeeth added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Jan 25, 2025
@Efnilite Efnilite added the PR available Issues which have a yet-to-be merged PR resolving it label Feb 25, 2025
@sovdeeth sovdeeth added completed The issue has been fully resolved and the change will be in the next Skript update. and removed PR available Issues which have a yet-to-be merged PR resolving it labels Mar 1, 2025
@sovdeeth sovdeeth closed this as completed Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update.
Projects
None yet
Development

No branches or pull requests

5 participants