Revert "keon#256 change strip_url_params3 to use OrderedDict to prevent failing test on non deterministic retrieval of dict keys for query string (keon#367)" (keon#368)

This reverts commit 81e7853.

Author: Hai Hoang Dang

algorithms/strings/strip_url_params.py

@@ -10,8 +10,6 @@
 import urllib
 import urllib.parse
 
-from collections import OrderedDict
-
 # Here is a very non-pythonic grotesque solution
 def strip_url_params1(url, params_to_strip=None):
 
@@ -39,7 +37,7 @@ def strip_url_params1(url, params_to_strip=None):
                     string = ''
                 else:
                     string += char
-            dict = OrderedDict()
+            dict = defaultdict(int)
             # logic for checking whether we should add the string to our result
             for i in key_value_string:
                 _token = i.split('=')

tests/test_strings.py

@@ -339,23 +339,23 @@ def test_roman_to_int(self):
         self.assertEqual(3999, roman_to_int("MMMCMXCIX"))
 
 
-class TestStripUrlParams(unittest.TestCase):
-    """[summary]
-    Test for the file strip_urls_params.py
-
-    Arguments:
-        unittest {[type]} -- [description]
-    """
-
-    def test_strip_url_params1(self):
-        self.assertEqual(strip_url_params1("www.saadbenn.com?a=1&b=2&a=2"), "www.saadbenn.com?a=1&b=2")
-        self.assertEqual(strip_url_params1("www.saadbenn.com?a=1&b=2", ['b']), "www.saadbenn.com?a=1")
-    def test_strip_url_params2(self):
-        self.assertEqual(strip_url_params2("www.saadbenn.com?a=1&b=2&a=2"), "www.saadbenn.com?a=1&b=2")
-        self.assertEqual(strip_url_params2("www.saadbenn.com?a=1&b=2", ['b']), "www.saadbenn.com?a=1")
-    def test_strip_url_params3(self):
-        self.assertEqual(strip_url_params3("www.saadbenn.com?a=1&b=2&a=2"), "www.saadbenn.com?a=1&b=2")
-        self.assertEqual(strip_url_params3("www.saadbenn.com?a=1&b=2", ['b']), "www.saadbenn.com?a=1")
+# class TestStripUrlParams(unittest.TestCase):
+#     """[summary]
+#     Test for the file strip_urls_params.py
+
+#     Arguments:
+#         unittest {[type]} -- [description]
+#     """
+
+#     def test_strip_url_params1(self):
+#         self.assertEqual(strip_url_params1("www.saadbenn.com?a=1&b=2&a=2"), "www.saadbenn.com?a=1&b=2")
+#         self.assertEqual(strip_url_params1("www.saadbenn.com?a=1&b=2", ['b']), "www.saadbenn.com?a=1")
+#     def test_strip_url_params2(self):
+#         self.assertEqual(strip_url_params2("www.saadbenn.com?a=1&b=2&a=2"), "www.saadbenn.com?a=1&b=2")
+#         self.assertEqual(strip_url_params2("www.saadbenn.com?a=1&b=2", ['b']), "www.saadbenn.com?a=1")
+#     def test_strip_url_params3(self):
+#         self.assertEqual(strip_url_params3("www.saadbenn.com?a=1&b=2&a=2"), "www.saadbenn.com?a=1&b=2")
+#         self.assertEqual(strip_url_params3("www.saadbenn.com?a=1&b=2", ['b']), "www.saadbenn.com?a=1")
 
 
 class TestValidateCoordinates(unittest.TestCase):