Skip to content

Minimum version of Eigen #19

@Lucas-Haubert

Description

@Lucas-Haubert

Following the README for installation of Eigen:
"the Eigen C++ template library - conda-forge | repo",
it comes that the suggested version is 3.4.

Moreover, we have guards on version 3.3, e.g.:

#if EIGEN_VERSION_AT_LEAST(3, 3, 90)
      .def(
          "rankUpdate",
          [](Chol &c, const VectorType &w, Scalar sigma) -> Chol & {
            return c.rankUpdate(w, sigma);
          },
          "If LL^* = A, then it becomes A + sigma * v v^*", "w"_a, "sigma"_a,
          nb::rv_policy::reference)
#else

Then should we remove them ?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions