Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem filling the gear piece mold #19

Open
wormzjl opened this issue Mar 26, 2017 · 7 comments
Open

Problem filling the gear piece mold #19

wormzjl opened this issue Mar 26, 2017 · 7 comments

Comments

@wormzjl
Copy link
Contributor

wormzjl commented Mar 26, 2017

If I take the mold out before the filling is completed then I'll get something like this, but the metal i'm using is copper
image
It can be put back into the vessel to become completely filled through

Also it seems that I can't make gears other than copper

@Shurgent
Copy link
Owner

This is weird.
The error is reproduced. I'll try to figure out where I screwed up...

@Shurgent
Copy link
Owner

So... As usual, the problem is that the ContainerLiquidVessel is hard-coded using four metals: Copper, Bronze, Bismuth Bronze and Black Bronze...
https://github.com/Deadrik/TFCraft/blob/master/src/Common/com/bioxx/tfc/Containers/ContainerLiquidVessel.java#L144
I'm confused ... Apparently I'll have to inherit this class and create my own ... I do not know whether I want this. I'm running out of fuse, I'm tired of bumping into such things ... It's easier, probably, to fork TFC and write my own than to put crutches every time...
Most likely, I will have to create my own Vessel to replace the original one...

@wormzjl
Copy link
Contributor Author

wormzjl commented Apr 16, 2017

Or just ASM it?

@Shurgent
Copy link
Owner

I do not have the skills of using ASM. But, apparently, I have to deal with this framework...

@wormzjl
Copy link
Contributor Author

wormzjl commented Apr 16, 2017

This mod has added some molds and works well
http://terrafirmacraft.com/f/topic/8401-tfc-079290130terramisc-random-stuff-and-things-for-tfc/
Maybe you can take a look at what he did

@Shurgent
Copy link
Owner

I don't see a link to the source code. The search on GitHub did not bring any results.

@wormzjl
Copy link
Contributor Author

wormzjl commented Apr 16, 2017

no it's not open source, but it's java :P
might ask him directly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants