rename refreshToken to unsafeRefreshToken

Author: isaacroldan

packages/app/src/cli/models/app/app.test-data.ts

@@ -1423,7 +1423,7 @@ export function testDeveloperPlatformClient(stubs: Partial<DeveloperPlatformClie
     organizationSource: OrganizationSource.BusinessPlatform,
     bundleFormat: 'zip',
     session: () => Promise.resolve(testPartnersUserSession),
-    refreshToken: () => Promise.resolve(testPartnersUserSession.token),
+    unsafeRefreshToken: () => Promise.resolve(testPartnersUserSession.token),
     accountInfo: () => Promise.resolve(testPartnersUserSession.accountInfo),
     appFromIdentifiers: (_app: AppApiKeyAndOrgId) => Promise.resolve(testOrganizationApp()),
     organizations: () => Promise.resolve(organizationsResponse),

packages/app/src/cli/utilities/developer-platform-client.test.ts

@@ -24,7 +24,7 @@ describe('createUnauthorizedHandler', () => {
     const result = await handler.handler()
 
     expect(result).toEqual({token: mockToken})
-    expect(mockClient.refreshToken).toHaveBeenCalledTimes(1)
+    expect(mockClient.unsafeRefreshToken).toHaveBeenCalledTimes(1)
   })
 
   test('reuses existing token refresh when one is in progress', async () => {
@@ -36,19 +36,19 @@ describe('createUnauthorizedHandler', () => {
     const result = await handler.handler()
 
     expect(result).toEqual({token: mockToken})
-    expect(mockClient.refreshToken).toHaveBeenCalledTimes(1)
+    expect(mockClient.unsafeRefreshToken).toHaveBeenCalledTimes(1)
   })
 
   test('handles token refresh failure and cleans up in-progress promise', async () => {
     const mockClient = createMockClient()
     const error = new Error('Token refresh failed')
-    mockClient.refreshToken = vi.fn().mockRejectedValue(error)
+    mockClient.unsafeRefreshToken = vi.fn().mockRejectedValue(error)
     const handler = createUnauthorizedHandler(mockClient)
 
     await expect(handler.handler()).rejects.toThrow(error)
     await expect(handler.handler()).rejects.toThrow(error)
 
     // The following is evidence that the finally block is called correctly
-    expect(mockClient.refreshToken).toHaveBeenCalledTimes(2)
+    expect(mockClient.unsafeRefreshToken).toHaveBeenCalledTimes(2)
   })
 })

packages/app/src/cli/utilities/developer-platform-client.ts

@@ -263,7 +263,12 @@ export interface DeveloperPlatformClient {
   readonly organizationSource: OrganizationSource
   readonly bundleFormat: 'zip' | 'br'
   session: () => Promise<PartnersSession>
-  refreshToken: () => Promise<string>
+  /**
+   * This is an unsafe method that should only be used when the session is expired.
+   * It is not safe to use this method in other contexts as it may lead to race conditions.
+   * Use only if you know what you are doing.
+   */
+  unsafeRefreshToken: () => Promise<string>
   accountInfo: () => Promise<PartnersSession['accountInfo']>
   appFromIdentifiers: (app: AppApiKeyAndOrgId) => Promise<OrganizationApp | undefined>
   organizations: () => Promise<Organization[]>
@@ -336,7 +341,7 @@ export function createUnauthorizedHandler(client: DeveloperPlatformClient): Unau
         return {token}
       } else {
         try {
-          tokenRefresher = client.refreshToken()
+          tokenRefresher = client.unsafeRefreshToken()
           inProgressRefreshes.set(client, tokenRefresher)
           const token = await tokenRefresher
           return {token}

packages/app/src/cli/utilities/developer-platform-client/app-management-client.ts

@@ -318,7 +318,7 @@ export class AppManagementClient implements DeveloperPlatformClient {
     return (await this.session()).businessPlatformToken
   }
 
-  async refreshToken(): Promise<string> {
+  async unsafeRefreshToken(): Promise<string> {
     const result = await ensureAuthenticatedAppManagementAndBusinessPlatform({noPrompt: true, forceRefresh: true})
     const session = await this.session()
     session.token = result.appManagementToken

packages/app/src/cli/utilities/developer-platform-client/partners-client.ts

@@ -273,7 +273,7 @@ export class PartnersClient implements DeveloperPlatformClient {
     return (await this.session()).token
   }
 
-  async refreshToken(): Promise<string> {
+  async unsafeRefreshToken(): Promise<string> {
     const {token} = await ensureAuthenticatedPartners([], process.env, {noPrompt: true, forceRefresh: true})
     const session = await this.session()
     if (token) {