Skip to content

Commit 5da23d9

Browse files
committed
Always avoid using native js "document" object for DOM manipulation in service portal. Instead we should use AngularJS equivalent capabilities to achieve the same.
1 parent 6d16276 commit 5da23d9

File tree

2 files changed

+58
-1
lines changed

2 files changed

+58
-1
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
tG-IQ3gIIotqELbKefsjaKLRXAfKT5UCb90GMAzdOGjWm3gW0SvUTgZCObB8HbG38f2ZIz_cGHzE8h1Dbh66hcWYk9onFL6yx5pPy_HaM03tfsR3bmu29LtBhi1Mlb2qAbhfkvO4ZC46mcJZPOxd0reUiW1n5LBiNyM23sGTwxRPuA-ooNcBOztJh_qeMvxknDn-Wm6RYSE1_8w4lwUtYIHInJeIMiyRoQ6D4F3pxo0xaXHl0LlOvFobeMC5LOlLL0dv4nck-oaNAvFiaOG1FvI-7ygRnMoaJHsnTeFhPcb097zMZaPlIAQqjF1L8Mdy7O90zW8eUAkdCvnDurh5aHeutoBb3jdPXC-nO628hbqe-N1KQV-pnFKBOrMaVdI3jTrJlc82fN6lNWtJiwIhcbZZ6SREA32cQvbZMdByYjdBEGFGo94JIR6rzuEsMfz-7ppaumipljUD60K3dg9yA1bAqJd--C1cqwrFursf_XaiGNxQ0LFwKjNKH-lJbSZ5mSffVV57477EX2XV3HEqx47EL5rmtZnG52C_E63ky0clzZLO_00Tl34mE04i_1YqUBXsqry27Ub4o0UksPESR1xjq5mjEKs1dOmpPE0KgBMhWhlNTamVrIdB5h7Z95cgx6n1O19jPnhRjg_lkYgvh_yV-x2uimlO5Hl7Gw6e08g
1+
i_BjMOi9sxzRAYEoKQTyqmvU0fzO1wvs16ONlSntq91XLDlYsoVVgLGnL_Pql8lXuhENdj6DQbjG8yBXFzaTNNrjSRo1tvTlKMSREQmPVQNfj2STT1IXYIehedgFy5Al1Av4anp18YO3u56S4GkD2V8yA-d8IgRwhmFuLB_bZmx2TEBUSQxXqKSsZhbe6oWn3wVb1L47k9RHwqyLIt9WphsEhP52Gey49IUC-I5iDm1Ko93syfvhdFL0FX2el5zCW3g31CG85wenOJYEsUCKZ109XJJWa_3JsYZQTlBlDzxQ2Bq8-DWpgydmWDhRBvHPURa4tlWEBRZuXC0HIQWvAX_gvueBdVRl8XRhnkE7tL-tnE-jGSf6SHQi73eBfj5oit8baCPzaVEYvVpxBl_AN5rRWxqXFxZv8XjJqgWDG-gO_dFntKZPDNvs3ikqemCuEeYEYzf8IMuj06xbumTB6DdxwY-dOHVuTQ5UZ5g2BKLTUfRBzqxFd5e655-CaL8RP1D9OXHjPn-aY6TNd-c4Rx_j36j3zJovj0svg8g-2i3WgnTCntlAsNrXRDtqRvl-a6-2RgEhQ1ug98qMHkEpRHhUwiAIA3-YEIpaxJt6i6qBwlpompDad8rAmltd_bP_W-xd6Ipzs-whgMH5KQZuCABwsqnsUQTN_gZ3rrbDvLg
Lines changed: 57 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,57 @@
1+
<?xml version="1.0" encoding="UTF-8"?><record_update table="scan_table_check">
2+
<scan_table_check action="INSERT_OR_UPDATE">
3+
<active>true</active>
4+
<advanced>true</advanced>
5+
<category>manageability</category>
6+
<conditions/>
7+
<description>Always avoid using native js "document" object for DOM manipulation in service portal. Instead we should use AngularJS equivalent capabilities to achieve the same.</description>
8+
<documentation_url/>
9+
<finding_type>scan_finding</finding_type>
10+
<name>Avoid using javascript "document" object in Portal</name>
11+
<priority>1</priority>
12+
<resolution_details/>
13+
<run_condition/>
14+
<score_max>100</score_max>
15+
<score_min>0</score_min>
16+
<score_scale>1</score_scale>
17+
<script><![CDATA[(function (finding, current) {
18+
var regex = /gel\s*\(|[\s\w\d]document\.[a-zA-Z]+|\.onchange\s*\(|\.onclick\s*\(|\$.+?\s*\(|Event\.|jQuery\s*\(/g;
19+
20+
var scriptValue = current.getValue("client_script") || "";
21+
var matches = scriptValue.match(regex);
22+
23+
if (matches) {
24+
matches.forEach(function(match) {
25+
finding.increment();
26+
});
27+
}
28+
})(finding, current);]]></script>
29+
<short_description>Avoid using javascript "document" object in Portal</short_description>
30+
<sys_class_name>scan_table_check</sys_class_name>
31+
<sys_created_by>admin</sys_created_by>
32+
<sys_created_on>2024-10-14 17:36:18</sys_created_on>
33+
<sys_id>e65c4d305315521000b51901a0490e38</sys_id>
34+
<sys_mod_count>0</sys_mod_count>
35+
<sys_name>Avoid using javascript "document" object in Portal</sys_name>
36+
<sys_package display_value="Example Instance Checks" source="x_appe_exa_checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_package>
37+
<sys_policy/>
38+
<sys_scope display_value="Example Instance Checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_scope>
39+
<sys_update_name>scan_table_check_e65c4d305315521000b51901a0490e38</sys_update_name>
40+
<sys_updated_by>admin</sys_updated_by>
41+
<sys_updated_on>2024-10-14 17:36:18</sys_updated_on>
42+
<table>sp_widget</table>
43+
<use_manifest>false</use_manifest>
44+
</scan_table_check>
45+
<sys_translated_text action="delete_multiple" query="documentkey=e65c4d305315521000b51901a0490e38"/>
46+
<sys_es_latest_script action="INSERT_OR_UPDATE">
47+
<id>e65c4d305315521000b51901a0490e38</id>
48+
<sys_created_by>admin</sys_created_by>
49+
<sys_created_on>2024-10-14 17:36:18</sys_created_on>
50+
<sys_id>54ae89b05315521000b51901a0490e99</sys_id>
51+
<sys_mod_count>0</sys_mod_count>
52+
<sys_updated_by>admin</sys_updated_by>
53+
<sys_updated_on>2024-10-14 17:36:18</sys_updated_on>
54+
<table>scan_table_check</table>
55+
<use_es_latest>true</use_es_latest>
56+
</sys_es_latest_script>
57+
</record_update>

0 commit comments

Comments
 (0)