Skip to content

Commit 21a90b1

Browse files
LacahLacah
authored
Merge branch 'master' into bgrk-instancescan
2 parents 23b6ce1 + c17ab54 commit 21a90b1

File tree

64 files changed

+3343
-8
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

64 files changed

+3343
-8
lines changed

‎.github/workflows/hacktrack.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ on:
1414
branches: master
1515
jobs:
1616
deployment:
17+
if: github.repository == 'ServiceNowDevProgram/example-instancescan-checks'
1718
runs-on: ubuntu-latest
1819
steps:
1920
# - name: Log payload

‎README.md

Lines changed: 195 additions & 8 deletions
Large diffs are not rendered by default.

‎ca8467c41b9abc10ce0f62c3b24bcbaa/author_elective_update/scan_linter_check_c2db61672f561110a1803e0ef699b64b.xml

Lines changed: 124 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,124 @@
1+
<?xml version="1.0" encoding="UTF-8"?><record_update table="scan_linter_check">
2+
<scan_linter_check action="DELETE">
3+
<active>true</active>
4+
<category>manageability</category>
5+
<description>In general, you should use the array literal notation when possible. It is easier to read, it gives the compiler a chance to optimize your code, and it's mostly faster too.</description>
6+
<documentation_url>https://www.java67.com/2014/08/difference-between-string-literal-and-new-String-object-Java.html</documentation_url>
7+
<finding_type>scan_finding</finding_type>
8+
<name>Don't use new Array()</name>
9+
<priority>4</priority>
10+
<resolution_details>Use [] instead of new Array().</resolution_details>
11+
<run_condition/>
12+
<score_max>100</score_max>
13+
<score_min>0</score_min>
14+
<score_scale>1</score_scale>
15+
<script><![CDATA[(function (engine) {
16+
17+
// Perform Linter Check
18+
engine.rootNode.visit(function(node) {
19+
if(node.getTypeName() === "NAME" && node.getNameIdentifier() === "Array" && node.getParent().getTypeName() === "NEW") {
20+
// Create scan finding
21+
engine.finding.incrementWithNode(node);
22+
}
23+
});
24+
25+
})(engine);]]></script>
26+
<short_description>Don't use new Array()</short_description>
27+
<sys_class_name>scan_linter_check</sys_class_name>
28+
<sys_created_by>admin</sys_created_by>
29+
<sys_created_on>2022-10-08 17:05:24</sys_created_on>
30+
<sys_id>c2db61672f561110a1803e0ef699b64b</sys_id>
31+
<sys_mod_count>0</sys_mod_count>
32+
<sys_name>Don't use new Array()</sys_name>
33+
<sys_package display_value="Example Instance Checks" source="x_appe_exa_checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_package>
34+
<sys_policy/>
35+
<sys_scope display_value="Example Instance Checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_scope>
36+
<sys_update_name>scan_linter_check_c2db61672f561110a1803e0ef699b64b</sys_update_name>
37+
<sys_updated_by>admin</sys_updated_by>
38+
<sys_updated_on>2022-10-08 17:05:24</sys_updated_on>
39+
</scan_linter_check>
40+
<sys_update_version action="INSERT_OR_UPDATE">
41+
<action>DELETE</action>
42+
<application display_value="Example Instance Checks">ca8467c41b9abc10ce0f62c3b24bcbaa</application>
43+
<file_path/>
44+
<instance_id>3b3779331b2d3d101024eb9b2d4bcb61</instance_id>
45+
<instance_name>dev181379</instance_name>
46+
<name>scan_linter_check_c2db61672f561110a1803e0ef699b64b</name>
47+
<payload>&lt;?xml version="1.0" encoding="UTF-8"?&gt;&lt;record_update table="scan_linter_check"&gt;
48+
&lt;scan_linter_check action="INSERT_OR_UPDATE"&gt;
49+
&lt;active&gt;true&lt;/active&gt;
50+
&lt;category&gt;manageability&lt;/category&gt;
51+
&lt;description&gt;In general, you should use the array literal notation when possible. It is easier to read, it gives the compiler a chance to optimize your code, and it's mostly faster too.&lt;/description&gt;
52+
&lt;documentation_url&gt;https://www.java67.com/2014/08/difference-between-string-literal-and-new-String-object-Java.html&lt;/documentation_url&gt;
53+
&lt;finding_type&gt;scan_finding&lt;/finding_type&gt;
54+
&lt;name&gt;Don't use new Array()&lt;/name&gt;
55+
&lt;priority&gt;4&lt;/priority&gt;
56+
&lt;resolution_details&gt;Use [] instead of new Array().&lt;/resolution_details&gt;
57+
&lt;run_condition/&gt;
58+
&lt;score_max&gt;100&lt;/score_max&gt;
59+
&lt;score_min&gt;0&lt;/score_min&gt;
60+
&lt;score_scale&gt;1&lt;/score_scale&gt;
61+
&lt;script&gt;&lt;![CDATA[(function (engine) {
62+
63+
// Perform Linter Check
64+
engine.rootNode.visit(function(node) {
65+
if(node.getTypeName() === "NAME" &amp;&amp; node.getNameIdentifier() === "Array" &amp;&amp; node.getParent().getTypeName() === "NEW") {
66+
// Create scan finding
67+
engine.finding.incrementWithNode(node);
68+
}
69+
});
70+
71+
})(engine);]]&gt;&lt;/script&gt;
72+
&lt;short_description&gt;Don't use new Array()&lt;/short_description&gt;
73+
&lt;sys_class_name&gt;scan_linter_check&lt;/sys_class_name&gt;
74+
&lt;sys_created_by&gt;admin&lt;/sys_created_by&gt;
75+
&lt;sys_created_on&gt;2022-10-08 17:05:24&lt;/sys_created_on&gt;
76+
&lt;sys_id&gt;c2db61672f561110a1803e0ef699b64b&lt;/sys_id&gt;
77+
&lt;sys_mod_count&gt;0&lt;/sys_mod_count&gt;
78+
&lt;sys_name&gt;Don't use new Array()&lt;/sys_name&gt;
79+
&lt;sys_package display_value="Example Instance Checks" source="x_appe_exa_checks"&gt;ca8467c41b9abc10ce0f62c3b24bcbaa&lt;/sys_package&gt;
80+
&lt;sys_policy/&gt;
81+
&lt;sys_scope display_value="Example Instance Checks"&gt;ca8467c41b9abc10ce0f62c3b24bcbaa&lt;/sys_scope&gt;
82+
&lt;sys_update_name&gt;scan_linter_check_c2db61672f561110a1803e0ef699b64b&lt;/sys_update_name&gt;
83+
&lt;sys_updated_by&gt;admin&lt;/sys_updated_by&gt;
84+
&lt;sys_updated_on&gt;2022-10-08 17:05:24&lt;/sys_updated_on&gt;
85+
&lt;/scan_linter_check&gt;
86+
&lt;/record_update&gt;</payload>
87+
<payload_hash>-1288508107</payload_hash>
88+
<record_name>Don't use new Array()</record_name>
89+
<reverted_from/>
90+
<source>a33d22c047397110243ff19f016d43fa</source>
91+
<source_table>sys_upgrade_history</source_table>
92+
<state>current</state>
93+
<sys_created_by>admin</sys_created_by>
94+
<sys_created_on>2023-10-05 20:43:22</sys_created_on>
95+
<sys_id>184d62c047397110243ff19f016d43a4</sys_id>
96+
<sys_mod_count>0</sys_mod_count>
97+
<sys_recorded_at>18b0194ac770000001</sys_recorded_at>
98+
<sys_updated_by>admin</sys_updated_by>
99+
<sys_updated_on>2023-10-05 20:43:22</sys_updated_on>
100+
<type>Linter Check</type>
101+
<update_guid>d44d62c0e739711006b12536250952a4</update_guid>
102+
<update_guid_history>d44d62c0e739711006b12536250952a4:-1288508107</update_guid_history>
103+
</sys_update_version>
104+
<sys_metadata_delete action="INSERT_OR_UPDATE">
105+
<sys_audit_delete display_value="Don't use new Array()">4976874c47797110243ff19f016d43ef</sys_audit_delete>
106+
<sys_class_name>sys_metadata_delete</sys_class_name>
107+
<sys_created_by>smartcarleen</sys_created_by>
108+
<sys_created_on>2023-10-05 22:33:28</sys_created_on>
109+
<sys_db_object display_value="" name="scan_linter_check">scan_linter_check</sys_db_object>
110+
<sys_id>0aa8c028e2c148aa908c575e038de241</sys_id>
111+
<sys_metadata>c2db61672f561110a1803e0ef699b64b</sys_metadata>
112+
<sys_mod_count>0</sys_mod_count>
113+
<sys_name>Don't use new Array()</sys_name>
114+
<sys_package display_value="Example Instance Checks" source="x_appe_exa_checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_package>
115+
<sys_parent/>
116+
<sys_policy/>
117+
<sys_scope display_value="Example Instance Checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_scope>
118+
<sys_scope_delete display_value="">30a78b9b9290467a96959a65d2b2d304</sys_scope_delete>
119+
<sys_update_name>scan_linter_check_c2db61672f561110a1803e0ef699b64b</sys_update_name>
120+
<sys_update_version display_value="scan_linter_check_c2db61672f561110a1803e0ef699b64b">184d62c047397110243ff19f016d43a4</sys_update_version>
121+
<sys_updated_by>smartcarleen</sys_updated_by>
122+
<sys_updated_on>2023-10-05 22:33:28</sys_updated_on>
123+
</sys_metadata_delete>
124+
</record_update>

‎ca8467c41b9abc10ce0f62c3b24bcbaa/author_elective_update/scan_table_check_0306196a07221110e765f9fc7c1ed07b.xml

Lines changed: 86 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,86 @@
1+
<?xml version="1.0" encoding="UTF-8"?><record_update table="scan_table_check">
2+
<scan_table_check action="DELETE">
3+
<active>true</active>
4+
<advanced>false</advanced>
5+
<category>manageability</category>
6+
<conditions table="sys_user_has_role">userISEMPTY^EQ<item endquery="false" field="user" goto="false" newquery="false" operator="ISEMPTY" or="false" value=""/>
7+
<item endquery="true" field="" goto="false" newquery="false" operator="=" or="false" value=""/>
8+
</conditions>
9+
<description/>
10+
<documentation_url/>
11+
<finding_type>scan_finding</finding_type>
12+
<name>User Roles from Deleted Users</name>
13+
<priority>3</priority>
14+
<resolution_details/>
15+
<run_condition/>
16+
<score_max>100</score_max>
17+
<score_min>0</score_min>
18+
<score_scale>1</score_scale>
19+
<script><![CDATA[(function (engine) {
20+
21+
// Add your code here
22+
23+
})(engine);]]></script>
24+
<short_description>Find role assignment records from users that no longer exist</short_description>
25+
<sys_class_name>scan_table_check</sys_class_name>
26+
<sys_created_by>admin</sys_created_by>
27+
<sys_created_on>2022-10-17 23:14:21</sys_created_on>
28+
<sys_id>0306196a07221110e765f9fc7c1ed07b</sys_id>
29+
<sys_mod_count>0</sys_mod_count>
30+
<sys_name>User Roles from Deleted Users</sys_name>
31+
<sys_package display_value="Example Instance Checks" source="x_appe_exa_checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_package>
32+
<sys_policy/>
33+
<sys_scope display_value="Example Instance Checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_scope>
34+
<sys_update_name>scan_table_check_0306196a07221110e765f9fc7c1ed07b</sys_update_name>
35+
<sys_updated_by>admin</sys_updated_by>
36+
<sys_updated_on>2022-10-17 23:14:21</sys_updated_on>
37+
<table>sys_user_has_role</table>
38+
<use_manifest>false</use_manifest>
39+
</scan_table_check>
40+
<sys_update_version action="INSERT_OR_UPDATE">
41+
<action>DELETE</action>
42+
<application display_value="Example Instance Checks">ca8467c41b9abc10ce0f62c3b24bcbaa</application>
43+
<file_path/>
44+
<instance_id>0fce25a8db402300439ef70fbf96190f</instance_id>
45+
<instance_name>dev71085</instance_name>
46+
<name>scan_table_check_0306196a07221110e765f9fc7c1ed07b</name>
47+
<payload>&lt;?xml version="1.0" encoding="UTF-8"?&gt;&lt;record_update table="scan_table_check"&gt;&lt;scan_table_check action="INSERT_OR_UPDATE"&gt;&lt;active&gt;true&lt;/active&gt;&lt;advanced&gt;false&lt;/advanced&gt;&lt;category&gt;manageability&lt;/category&gt;&lt;conditions table="sys_user_has_role"&gt;userISEMPTY^EQ&lt;item endquery="false" field="user" goto="false" newquery="false" operator="ISEMPTY" or="false" value=""/&gt;&lt;item endquery="true" field="" goto="false" newquery="false" operator="=" or="false" value=""/&gt;&lt;/conditions&gt;&lt;description/&gt;&lt;documentation_url/&gt;&lt;finding_type&gt;scan_finding&lt;/finding_type&gt;&lt;name&gt;User Roles from Deleted Users&lt;/name&gt;&lt;priority&gt;3&lt;/priority&gt;&lt;resolution_details/&gt;&lt;run_condition/&gt;&lt;score_max&gt;100&lt;/score_max&gt;&lt;score_min&gt;0&lt;/score_min&gt;&lt;score_scale&gt;1&lt;/score_scale&gt;&lt;script&gt;&lt;![CDATA[(function (engine) {
48+
49+
// Add your code here
50+
51+
})(engine);]]&gt;&lt;/script&gt;&lt;short_description&gt;Find role assignment records from users that no longer exist&lt;/short_description&gt;&lt;sys_class_name&gt;scan_table_check&lt;/sys_class_name&gt;&lt;sys_created_by&gt;admin&lt;/sys_created_by&gt;&lt;sys_created_on&gt;2022-10-17 23:14:21&lt;/sys_created_on&gt;&lt;sys_id&gt;0306196a07221110e765f9fc7c1ed07b&lt;/sys_id&gt;&lt;sys_mod_count&gt;0&lt;/sys_mod_count&gt;&lt;sys_name&gt;User Roles from Deleted Users&lt;/sys_name&gt;&lt;sys_package display_value="Example Instance Checks" source="x_appe_exa_checks"&gt;ca8467c41b9abc10ce0f62c3b24bcbaa&lt;/sys_package&gt;&lt;sys_policy/&gt;&lt;sys_scope display_value="Example Instance Checks"&gt;ca8467c41b9abc10ce0f62c3b24bcbaa&lt;/sys_scope&gt;&lt;sys_update_name&gt;scan_table_check_0306196a07221110e765f9fc7c1ed07b&lt;/sys_update_name&gt;&lt;sys_updated_by&gt;admin&lt;/sys_updated_by&gt;&lt;sys_updated_on&gt;2022-10-17 23:14:21&lt;/sys_updated_on&gt;&lt;table&gt;sys_user_has_role&lt;/table&gt;&lt;use_manifest&gt;false&lt;/use_manifest&gt;&lt;/scan_table_check&gt;&lt;/record_update&gt;</payload>
52+
<payload_hash>1517693554</payload_hash>
53+
<record_name>User Roles from Deleted Users</record_name>
54+
<reverted_from/>
55+
<source>d17519a607221110e765f9fc7c1ed0f4</source>
56+
<source_table>sys_update_set</source_table>
57+
<state>previous</state>
58+
<sys_created_by>admin</sys_created_by>
59+
<sys_created_on>2022-10-17 23:14:21</sys_created_on>
60+
<sys_id>da9615aa07221110e765f9fc7c1ed05e</sys_id>
61+
<sys_mod_count>0</sys_mod_count>
62+
<sys_recorded_at>183e83a09cd0000001</sys_recorded_at>
63+
<sys_updated_by>admin</sys_updated_by>
64+
<sys_updated_on>2022-10-17 23:14:21</sys_updated_on>
65+
<type>Table Check</type>
66+
<update_guid>169615aaf122111071af545cbffcdb5e</update_guid>
67+
<update_guid_history>169615aaf122111071af545cbffcdb5e:1517693554</update_guid_history>
68+
</sys_update_version>
69+
<sys_metadata_delete action="INSERT_OR_UPDATE">
70+
<sys_audit_delete display_value="User Roles from Deleted Users">0ac7ddaa07221110e765f9fc7c1ed09b</sys_audit_delete>
71+
<sys_class_name>sys_metadata_delete</sys_class_name>
72+
<sys_created_by>admin</sys_created_by>
73+
<sys_created_on>2022-10-17 23:19:31</sys_created_on>
74+
<sys_db_object display_value="" name="scan_table_check">scan_table_check</sys_db_object>
75+
<sys_id>17859954039f4abebc7d0e2289a8edc4</sys_id>
76+
<sys_metadata>0306196a07221110e765f9fc7c1ed07b</sys_metadata>
77+
<sys_name>User Roles from Deleted Users</sys_name>
78+
<sys_package display_value="Example Instance Checks" source="x_appe_exa_checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_package>
79+
<sys_parent/>
80+
<sys_policy/>
81+
<sys_scope display_value="Example Instance Checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_scope>
82+
<sys_scope_delete display_value="">30a78b9b9290467a96959a65d2b2d304</sys_scope_delete>
83+
<sys_update_name>scan_table_check_0306196a07221110e765f9fc7c1ed07b</sys_update_name>
84+
<sys_update_version display_value="scan_table_check_0306196a07221110e765f9fc7c1ed07b">da9615aa07221110e765f9fc7c1ed05e</sys_update_version>
85+
</sys_metadata_delete>
86+
</record_update>

0 commit comments

Comments
 (0)