MacPDF: Make MacPDFWindowController validateMenuItem not call super

nico · nico · commit f9e89572e83f · 2025-02-07T22:24:43.000-05:00
NSWindowController does not conform to NSMenuItemValidation per docs. https://developer.apple.com/library/archive/documentation/Cocoa/Conceptual/MenuList/Articles/EnablingMenuItems.html "Automatic Menu Enabling" also suggests that this doesn't make sense conceptually. Defaulting to `NO` makes it more likely we'll remember to add new menu entries that might need dynamic enabling depending on some state, so let's go with that for now.
diff --git a/Meta/Lagom/Contrib/MacPDF/MacPDFWindowController.mm b/Meta/Lagom/Contrib/MacPDF/MacPDFWindowController.mm
@@ -138,7 +138,7 @@ - (BOOL)validateMenuItem:(NSMenuItem*)item
         return YES;
     if (item.action == @selector(showGoToPageDialog:))
         return _pdfDocument.pdf ? YES : NO;
-    return [super validateMenuItem:item];
+    return NO;
 }
 
 - (IBAction)toggleShowClippingPaths:(id)sender

Original file line number	Diff line number	Diff line change
`@@ -138,7 +138,7 @@ - (BOOL)validateMenuItem:(NSMenuItem*)item`
`138`	`138`	`return YES;`
`139`	`139`	`if (item.action == @selector(showGoToPageDialog:))`
`140`	`140`	`return _pdfDocument.pdf ? YES : NO;`
`141`		`- return [super validateMenuItem:item];`
	`141`	`+ return NO;`
`142`	`142`	`}`
`143`	`143`
`144`	`144`	`- (IBAction)toggleShowClippingPaths:(id)sender`