Skip to content

Commit 5616096

Browse files
committed
[rb] add guards to failing firefox tests
1 parent c7e842a commit 5616096

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

rb/spec/integration/selenium/webdriver/action_builder_spec.rb

+2-1
Original file line numberDiff line numberDiff line change
@@ -317,7 +317,8 @@ module WebDriver
317317
end
318318

319319
describe '#scroll_by' do
320-
it 'scrolls by given amount', except: {browser: :firefox, reason: 'returns false on firefox'} do
320+
it 'scrolls by given amount',
321+
exclude: {driver: :firefox, reason: 'inconsistent behavior between versions'} do
321322
driver.navigate.to url_for('scrolling_tests/frame_with_nested_scrolling_frame_out_of_view.html')
322323
footer = driver.find_element(tag_name: 'footer')
323324
delta_y = footer.rect.y.round

rb/spec/integration/selenium/webdriver/driver_spec.rb

+1
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ module WebDriver
2424
describe Driver, exclusive: {bidi: false, reason: 'Not yet implemented with BiDi'} do
2525
it_behaves_like 'driver that can be started concurrently', exclude: [
2626
{browser: %i[safari safari_preview]},
27+
{browser: :firefox, rbe: true, reason: 'https://github.com/mozilla/geckodriver/issues/2219'},
2728
{driver: :remote, rbe: true, reason: 'Cannot start 2+ drivers at once.'}
2829
]
2930

0 commit comments

Comments
 (0)