-
Notifications
You must be signed in to change notification settings - Fork 5
feat(sc): enable ReSpeaker Lite support and fix sample streaming #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Wkstr
wants to merge
6
commits into
Seeed-Studio:main
Choose a base branch
from
Wkstr:feature/respeaker
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
273d2fa
feat(sc): add ReSpeaker Lite‘s support
Wkstr c9208da
fix(sc): adapt sample stream
Wkstr 87243b3
chore: rename compile options
Wkstr ccd5f07
feat(SensorI2SXMOS): implement hardware-accelerated 32-to-16bit conve…
Wkstr 648cbfa
refactor: move upsampling to API
Wkstr 0b16075
merge: sync with main to incorporate latest updates
Wkstr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -58,7 +58,13 @@ static size_t getFreeMemorySize() noexcept | |
|
|
||
| static constexpr const char DEVICE_MODEL[] = "ESP32-S3"; | ||
| static constexpr const char DEVICE_VERSION[] = "1.0.0"; | ||
| #if defined(PORTING_BOARD_MODEL_RESPEAKER_LITE) && PORTING_BOARD_MODEL_RESPEAKER_LITE | ||
| static constexpr const char DEVICE_NAME[] = "ReSpeaker Lite (XIAO ESP32S3)"; | ||
| #elif defined(PORTING_BOARD_MODEL_XIAO_S3) && PORTING_BOARD_MODEL_XIAO_S3 | ||
| static constexpr const char DEVICE_NAME[] = "XIAO ESP32-S3"; | ||
| #else | ||
| static constexpr const char DEVICE_NAME[] = "XIAO ESP32-S3"; | ||
| #endif | ||
|
Comment on lines
+61
to
+67
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 这的默认的逻辑建议直接 |
||
| static constexpr const size_t DEVICE_MEMORY_SIZE = 8 * 1024 * 1024; | ||
| static constexpr const size_t DEVICE_NAME_LENGTH_MAX = 64; | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里这样写缺少 mutual exclusivity 和 scalability,之后改用 menuconfig 来控制吧,也可以参考下面这种写法: