Skip to content

Commit 066e994

Browse files
author
Soumendra Daas
committed
- Upgrading to Java 17
- Minor Update to Doc - Trying to fix fiddly github actions
1 parent 9e4d98d commit 066e994

File tree

4 files changed

+18
-13
lines changed

4 files changed

+18
-13
lines changed

Diff for: .github/workflows/maven.yml

+7-5
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
# See https://github.com/actions/starter-workflows/blob/main/ci/maven.yml
2+
# and https://github.com/actions/setup-java
13
name: Java CI with Maven
24
on:
35
push:
@@ -8,12 +10,12 @@ jobs:
810
build:
911
runs-on: ubuntu-latest
1012
steps:
11-
- uses: actions/checkout@v2
12-
- name: Set up JDK 11
13-
uses: actions/setup-java@v2
13+
- uses: actions/checkout@v3
14+
- name: Set up JDK 17
15+
uses: actions/setup-java@v3
1416
with:
15-
java-version: '11'
16-
distribution: 'adopt'
17+
java-version: '17'
18+
distribution: 'corretto'
1719
cache: maven
1820
- name: Build with Maven
1921
run: mvn -B package --file pom.xml

Diff for: .travis.yml

-5
This file was deleted.

Diff for: README.md

+10-2
Original file line numberDiff line numberDiff line change
@@ -111,17 +111,25 @@ master branch. See [maven.yml](.github/workflows/maven.yml)
111111

112112
### Release process
113113

114+
See the process to [prepare](https://maven.apache.org/maven-release/maven-release-plugin/usage/prepare-release.html)
115+
and [perform](https://maven.apache.org/maven-release/maven-release-plugin/usage/perform-release.html) the
116+
release, but the steps are ...
117+
114118
* Make sure that all files are committed
115119
* `mvn test`
116120
* `mvn release:prepare -DdryRun=true`
121+
* You will be prompted for the release version to use
117122
* `mvn release:clean`
118123
* `mvn release:prepare`
119124
* `mvn release:perform`
120125
* Assuming that we are releasing `A.B.C`
121126
* At this point the pom.xml should have been updated to the `next-version-SNAPSHOT` version
122-
* There should a github tag called `vA.B.C`
123-
* We still need to create a Release (and release notes) manually from this tag.
127+
* Run `git tag`. There should a github tag called `vA.B.C`
124128

129+
* We still need to create a Release (and release notes) manually from this tag.
130+
* Go to `https://github.com/Sdaas/hello-karate/tags`
131+
* Select the latest tag and `Release` it
132+
125133
### References
126134

127135
* [Karate DSL ](https://github.com/karatelabs/karate)

Diff for: pom.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
<description>Getting started with Karate</description>
1515

1616
<properties>
17-
<java.version>11</java.version>
17+
<java.version>17</java.version>
1818

1919
<junit-jupiter.version>5.9.3</junit-jupiter.version>
2020
<karate.version>1.4.1</karate.version>

0 commit comments

Comments
 (0)