Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug in Surrogates.jl RTEA #504

Open
IJ05 opened this issue Jan 8, 2025 · 0 comments
Open

Possible bug in Surrogates.jl RTEA #504

IJ05 opened this issue Jan 8, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@IJ05
Copy link

IJ05 commented Jan 8, 2025

Describe the bug 🐞
Hello,
This is regarding a discrepancy that I have noticed while using the Surrogates.jl RTEA optimizer.
The mutated solutions according to lines: 1882 and 1883 are labelled as β€œx_new” and β€œy_new”. But when they are added back to the surrogate model, they are labelled as β€œnew_x” and β€œnew_y.” Is this a mistake, or have I got it completely wrong?

Expected behavior
I believe
add_point!(surrRTEA, new_x, new_y)
should be changed to:
add_point!(surrRTEA, x_new, y_new)

  • Output of using Pkg; Pkg.status()
Status `C:\Users\user\.julia\environments\v1.11\Project.toml`
  [31c24e10] Distributions v0.25.115
  [86b6b26d] Evolutionary v0.11.1
βŒƒ [f6369f11] ForwardDiff v0.10.37
βŒƒ [e9467ef8] GLMakie v0.10.16
  [af5da776] GlobalSensitivity v2.7.0
  [f67ccb44] HDF5 v0.17.2
  [f213a82b] HomotopyContinuation v2.12.0
βŒƒ [7073ff75] IJulia v1.25.0
βŒ… [ee78f7c6] Makie v0.21.16
βŒƒ [8913a72c] NonlinearSolve v4.1.0
βŒƒ [91a5bcdd] Plots v1.40.8
  [274fc56d] PythonPlot v1.0.5
  [8a4e6c94] QuasiMonteCarlo v0.3.3
βŒƒ [1ed8b502] SciMLSensitivity v7.70.0
  [6fc51010] Surrogates v6.10.0
  [37e2e46d] LinearAlgebra v1.11.0
  • Output of versioninfo()
Commit 501a4f25c2 (2024-10-07 11:40 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Windows (x86_64-w64-mingw32)
  CPU: 16 Γ— AMD Ryzen 7 4700G with Radeon Graphics         
  WORD_SIZE: 64
  LLVM: libLLVM-16.0.6 (ORCJIT, znver2)
Threads: 1 default, 0 interactive, 1 GC (on 16 virtual cores)```
@IJ05 IJ05 added the bug Something isn't working label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant