address code revioew

Author: oscardssmith

Diff for: src/integrators/integrator_utils.jl

@@ -102,20 +102,20 @@ function _savevalues!(integrator, force_save, reduce_size)::Tuple{Bool, Bool}
                             [k[integrator.opts.save_idxs] for k in integrator.k],
                             false)
                     end
-                    if integrator.alg isa DAEAlgorithm
-                        if integrator.opts.save_idxs === nothing
-                            copyat_or_push!(integrator.sol.du, integrator.saveiter, integrator.du)
-                        else
-                            copyat_or_push!(integrator.sol.du, integrator.saveiter,
-                                integrator.du[integrator.opts.save_idxs], false)
-                        end
-                    end
                 end
             end
             if integrator.alg isa OrdinaryDiffEqCompositeAlgorithm
                 copyat_or_push!(integrator.sol.alg_choice, integrator.saveiter,
                     integrator.cache.current)
             end
+            if integrator.opts.save_du
+                if integrator.opts.save_idxs === nothing
+                    copyat_or_push!(integrator.sol.du, integrator.saveiter, integrator(integrator.t, Val{1}))
+                else
+                    copyat_or_push!(integrator.sol.du, integrator.saveiter,
+                        integrator(integrator.t, Val{1}, idxs=integrator.opts.save_idxs), false)
+                end
+            end
         end
     end
     if force_save || (integrator.opts.save_everystep &&
@@ -142,20 +142,20 @@ function _savevalues!(integrator, force_save, reduce_size)::Tuple{Bool, Bool}
                         [k[integrator.opts.save_idxs] for k in integrator.k],
                         false)
                 end
-                if integrator.alg isa DAEAlgorithm
-                    if integrator.opts.save_idxs === nothing
-                        copyat_or_push!(integrator.sol.du, integrator.saveiter, integrator.du)
-                    else
-                        copyat_or_push!(integrator.sol.du, integrator.saveiter,
-                            integrator.du[integrator.opts.save_idxs], false)
-                    end
-                end
             end
         end
         if integrator.alg isa OrdinaryDiffEqCompositeAlgorithm
             copyat_or_push!(integrator.sol.alg_choice, integrator.saveiter,
                 integrator.cache.current)
         end
+        if integrator.opts.save_du
+            if integrator.opts.save_idxs === nothing
+                copyat_or_push!(integrator.sol.du, integrator.saveiter, integrator(integrator.t, Val{1}))
+            else
+                copyat_or_push!(integrator.sol.du, integrator.saveiter,
+                    integrator(integrator.t, Val{1}, idxs=integrator.opts.save_idxs), false)
+            end
+        end
     end
     reduce_size && resize!(integrator.k, integrator.kshortsize)
     return saved, savedexactly

Diff for: src/integrators/type.jl

@@ -46,6 +46,7 @@ mutable struct DEOptions{absType, relType, QT, tType, Controller, F1, F2, F3, F4
     force_dtmin::Bool
     advance_to_tstop::Bool
     stop_at_next_tstop::Bool
+    save_du::Bool
 end
 
 TruncatedStacktraces.@truncate_stacktrace DEOptions

Diff for: src/solve.jl

@@ -70,6 +70,7 @@ function DiffEqBase.__init(prob::Union{DiffEqBase.AbstractODEProblem,
     alias_u0 = false,
     alias_du0 = false,
     initializealg = DefaultInit(),
+    save_du = false,
     kwargs...) where {recompile_flag}
     if prob isa DiffEqBase.AbstractDAEProblem && alg isa OrdinaryDiffEqAlgorithm
         error("You cannot use an ODE Algorithm with a DAEProblem")
@@ -407,7 +408,8 @@ function DiffEqBase.__init(prob::Union{DiffEqBase.AbstractODEProblem,
         unstable_check,
         verbose, calck, force_dtmin,
         advance_to_tstop,
-        stop_at_next_tstop)
+        stop_at_next_tstop,
+        save_du)
 
     stats = SciMLBase.DEStats(0)
     differential_vars = prob isa DAEProblem ? prob.differential_vars : get_differential_vars(f, u)