Merge branch 'dtmin0'

Author: ChrisRackauckas

Project.toml

@@ -1,7 +1,7 @@
 name = "OrdinaryDiffEq"
 uuid = "1dea7af3-3e70-54e6-95c3-0bf5283fa5ed"
 authors = ["Chris Rackauckas <[email protected]>", "Yingbo Ma <[email protected]>"]
-version = "6.65.0"
+version = "6.66.0"
 
 [deps]
 ADTypes = "47edcb42-4c32-4615-8424-f2b9edc5f35b"

src/solve.jl

@@ -31,7 +31,7 @@ function DiffEqBase.__init(prob::Union{DiffEqBase.AbstractODEProblem,
                 (dense) || !isempty(saveat), # and no dense output
     dt = alg isa FunctionMap && isempty(tstops) ?
          eltype(prob.tspan)(1) : eltype(prob.tspan)(0),
-    dtmin = nothing,
+    dtmin = eltype(prob.tspan)(0),
     dtmax = eltype(prob.tspan)((prob.tspan[end] - prob.tspan[1])),
     force_dtmin = false,
     adaptive = anyadaptive(alg),
@@ -281,7 +281,7 @@ function DiffEqBase.__init(prob::Union{DiffEqBase.AbstractODEProblem,
             # For fixed dt, the only time dtmin makes sense is if it's smaller than eps().
             # Therefore user specified dtmin doesn't matter, but we need to ensure dt>=eps()
             # to prevent infinite loops.
-            abs(dt) < DiffEqBase.prob2dtmin(prob) &&
+            abs(dt) < dtmin &&
                 throw(ArgumentError("Supplied dt is smaller than dtmin"))
             steps = ceil(Int, internalnorm((tspan[2] - tspan[1]) / dt, tspan[1]))
         end
@@ -358,8 +358,6 @@ function DiffEqBase.__init(prob::Union{DiffEqBase.AbstractODEProblem,
         controller = default_controller(_alg, cache, qoldinit, beta1, beta2)
     end
 
-    dtmin === nothing && (dtmin = DiffEqBase.prob2dtmin(prob))
-
     save_end_user = save_end
     save_end = save_end === nothing ?
                save_everystep || isempty(saveat) || saveat isa Number ||

test/algconvergence/symplectic_tests.jl

@@ -89,7 +89,7 @@ prob_direct=SecondOrderODEProblem(motionfuncDirect1,v0_direct,u0_direct,tspan,pa
 dt=2e-8
 ref=solve(prob_direct,DPRKN12(),abstol=1e-12,reltol=1e-12,maxiters=1e7,saveat=0.01)
 
-@testset "symplectic time-dependent $alg-$iip-$pa" for (alg, x, d) in ALGOS
-    sol=solve(prob_direct,alg,dt=dt,saveat=0.01)
-    @test maximum(ref-sol) < 1e-3
+@testset "symplectic time-dependent $alg" for (alg, x, d) in ALGOS
+    sol=solve(prob_direct,alg(),dt=dt,saveat=0.01)
+    @test maximum(ref[4,:]-sol[4,:]) < 3e-3
 end

test/downstream/delaydiffeq.jl

@@ -24,7 +24,7 @@ using Test
         @test sol.errors[:l∞] < error
 
         sol_scalar = solve(prob_scalar, ddealg)
-        @test sol.t ≈ sol_scalar.t
+        @test sol.t ≈ sol_scalar.t atol=1e-6
         @test sol[1, :] ≈ sol_scalar.u
     end
 end

test/integrators/check_error.jl

@@ -5,7 +5,7 @@ u0 = 0.0 # explosion time is 1.0
 tspan = (0.0, 10.0)
 prob = ODEProblem(f_ec, u0, tspan)
 options = [:reltol => 1e-8, :abstol => 1e-8, :verbose => false]
-desired_code = ReturnCode.DtLessThanMin
+desired_code = ReturnCode.MaxIters
 
 # Test that sol.retcode is set to the correct value by various ways to
 # invoke integrator.

test/interface/ode_initdt_tests.jl

@@ -28,7 +28,7 @@ prob = remake(prob, u0 = u0, tspan = tspan)
 tspan = T.((2000, 2100))
 prob = remake(prob, tspan = tspan)
 # set maxiters to prevent infinite loop on test failure
-@test_throws ArgumentError solve(prob, Euler(); dt = T(0.0001), maxiters = 10)
+@test solve(prob, Euler(); dt = T(0.0001), maxiters = 10).retcode == SciMLBase.ReturnCode.MaxIters
 
 function rober(du, u, p, t)
     y₁, y₂, y₃ = u