step is active at start time

for consistency with
- other implementations
- literature
- the other sources in the same file

Author: baggepinnen

src/Blocks/sources.jl

@@ -328,7 +328,7 @@ Generate step signal.
     pars = @parameters offset=offset start_time=start_time height=height duration=duration
     equation = if smooth == false # use comparison in case smooth is a float
         offset +
-        ifelse((start_time < t) & (t < start_time + duration), height, zero(height))
+        ifelse((start_time <= t) & (t < start_time + duration), height, zero(height))
     else
         smooth === true && (smooth = 1e-5)
         if duration_numeric == Inf

src/Hydraulic/IsothermalCompressible/IsothermalCompressible.jl

@@ -14,7 +14,8 @@ using IfElse: ifelse
 export HydraulicPort, HydraulicFluid
 include("utils.jl")
 
-export Cap, Tube, FixedVolume, DynamicVolume, Open, FlowDivider, Valve, Volume, SpoolValve, SpoolValve2Way, Actuator
+export Cap, Tube, FixedVolume, DynamicVolume, Open, FlowDivider, Valve, Volume, SpoolValve,
+       SpoolValve2Way, Actuator
 include("components.jl")
 
 export MassFlow, Pressure, FixedPressure

test/Blocks/sources.jl

@@ -233,6 +233,7 @@ end
 
     @test sol.retcode == Success
     @test sol[src.output.u]≈step.(sol.t, offset, height, start_time) atol=1e-2
+    @test sol(start_time, idxs = src.output.u) == height + offset # Test that the step is applied at the start time
 
     # test with duration
     duration = 1.2