Skip to content

Commit 0a4a205

Browse files
authored
Enable strictPropertyInitialization (element-hq#25735)
1 parent 6726b93 commit 0a4a205

File tree

2 files changed

+1
-40
lines changed

2 files changed

+1
-40
lines changed

.github/workflows/static_analysis.yaml

-38
Original file line numberDiff line numberDiff line change
@@ -26,44 +26,6 @@ jobs:
2626
- name: Typecheck
2727
run: "yarn run lint:types"
2828

29-
tsc-strict:
30-
name: Typescript Strict Error Checker
31-
if: github.event_name == 'pull_request'
32-
runs-on: ubuntu-latest
33-
permissions:
34-
pull-requests: read
35-
checks: write
36-
steps:
37-
- uses: actions/checkout@v3
38-
39-
- name: Install Deps
40-
run: "scripts/layered.sh"
41-
42-
- name: Get diff lines
43-
id: diff
44-
uses: Equip-Collaboration/diff-line-numbers@e752977e2cb4207d671bb9e4dad18c07c1b73d52 # v1.1.0
45-
with:
46-
include: '["\\.tsx?$"]'
47-
48-
- name: Detecting files changed
49-
id: files
50-
uses: futuratrepadeira/changed-files@0239328a3a6268aad16af7c3e4efc78e32d6c0f0 # v4.0.1
51-
with:
52-
repo-token: ${{ secrets.GITHUB_TOKEN }}
53-
pattern: '^.*\.tsx?$'
54-
55-
- uses: t3chguy/typescript-check-action@main
56-
with:
57-
repo-token: ${{ secrets.GITHUB_TOKEN }}
58-
use-check: false
59-
check-fail-mode: added
60-
output-behaviour: annotate
61-
ts-extra-args: "--strict --noImplicitAny"
62-
files-changed: ${{ steps.files.outputs.files_updated }}
63-
files-added: ${{ steps.files.outputs.files_created }}
64-
files-deleted: ${{ steps.files.outputs.files_deleted }}
65-
line-numbers: ${{ steps.diff.outputs.lineNumbers }}
66-
6729
i18n_lint:
6830
name: "i18n Check"
6931
uses: matrix-org/matrix-react-sdk/.github/workflows/i18n_check.yml@develop

tsconfig.json

+1-2
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,7 @@
1313
"declaration": true,
1414
"jsx": "react",
1515
"lib": ["es2020", "dom", "dom.iterable"],
16-
"strict": true,
17-
"useUnknownInCatchVariables": false
16+
"strict": true
1817
},
1918
"include": [
2019
"./node_modules/matrix-js-sdk/src/@types/*.d.ts",

0 commit comments

Comments
 (0)