Skip to content

Commit d314a3e

Browse files
committed
Rework tests to use es6/JSX and power-assert
1 parent cf24cda commit d314a3e

14 files changed

+241
-351
lines changed

.babelrc

+9-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,11 @@
11
{
2-
"stage": 0
2+
"stage": 0,
3+
"env": {
4+
"test": {
5+
"plugins": [
6+
// Makes power-assert work
7+
"espower"
8+
]
9+
}
10+
}
311
}

.eslintrc

+3-4
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
{
22
root: true,
3+
parser: "babel-eslint",
34
extends: "eslint:recommended",
45
rules: {
56
strict: 0,
@@ -16,9 +17,7 @@
1617
env: {
1718
browser: true,
1819
node: true,
19-
mocha: true
20-
},
21-
ecmaFeatures: {
22-
jsx: true
20+
mocha: true,
21+
es6: true
2322
}
2423
}

.jsfmtrc

+17
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
{
2+
"extensions": [
3+
"js",
4+
"jsx"
5+
],
6+
"plugins": [
7+
"esformatter-jsx"
8+
],
9+
"jsx": {
10+
"formatJSX": true,
11+
"attrsOnSameLineAsTag": false,
12+
"spaceInJSXExpressionContainers": "",
13+
"maxAttrsOnTag": 2,
14+
"firstAttributeOnSameLine": true,
15+
"alignWithFirstAttribute": false
16+
}
17+
}

.jshintrc

-20
This file was deleted.

Makefile

+5-5
Original file line numberDiff line numberDiff line change
@@ -13,17 +13,17 @@ test: test-unit test-server
1313
@echo "The browser test suite should be run before commit. Run 'make test-local' to run it."
1414

1515
test-unit:
16-
@./node_modules/.bin/mocha -R spec -b tests/unit/*.js
16+
@env NODE_ENV=test ./node_modules/.bin/mocha -R spec --compilers js:babel/register -b tests/unit/*.js
1717

1818
test-server:
19-
@./node_modules/.bin/mocha -R spec -b tests/server/*.js
19+
@env NODE_ENV=test ./node_modules/.bin/mocha -R spec --compilers js:babel/register -b tests/server/*.js
2020

2121
test-local:
22-
@./node_modules/.bin/babel tests/browser/browser-jsx.jsx > tests/browser/browser-jsx.js
23-
@./node_modules/.bin/zuul --local 3000 -- tests/browser/*.js
22+
@env NODE_ENV=test ./node_modules/.bin/babel tests/browser/browser-jsx.jsx > tests/browser/browser-jsx.js
23+
@env NODE_ENV=test ./node_modules/.bin/zuul --local 3000 -- tests/browser/*.js
2424

2525
test-cloud:
26-
@./node_modules/.bin/zuul -- tests/browser/*.js
26+
@env NODE_ENV=test ./node_modules/.bin/zuul -- tests/browser/*.js
2727

2828
release-patch: test lint
2929
@$(call release,patch)

package.json

+4-1
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,16 @@
1111
},
1212
"devDependencies": {
1313
"babel": "^5.8.23",
14+
"babel-eslint": "^5.0.0-beta6",
15+
"babel-plugin-espower": "^1.1.0",
1416
"browserify": "^11.2.0",
1517
"browserify-shim": "^3.8.10",
1618
"envify": "^3.4.0",
1719
"eslint": "^1.6.0",
1820
"eslint-plugin-react": "^3.5.1",
1921
"jsxhint": "^0.15.1",
2022
"mocha": "^2.3.3",
23+
"power-assert": "^1.2.0",
2124
"semver": "^5.1.0",
2225
"zuul": "^3.6.0"
2326
},
@@ -61,4 +64,4 @@
6164
"publishConfig": {
6265
"registry": "https://registry.npmjs.org"
6366
}
64-
}
67+
}

tests/.jshintrc

-27
This file was deleted.

tests/browser/PathnameEnvironment.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
"use strict";
22

3-
var assert = require('assert');
3+
var assert = require('power-assert');
44
var PathnameEnvironment = require('../../lib/environment/PathnameEnvironment');
55

66
describe('PathnameEnvironment', function() {

tests/browser/QueryStringKeyEnvironment.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
"use strict";
22

3-
var assert = require('assert');
3+
var assert = require('power-assert');
44
var QuerystringKeyEnvironment = require('../../lib/environment/QuerystringKeyEnvironment');
55

66
describe('QuerystringKeyEnvironment', function() {

tests/browser/browser-jsx.js

+10-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
'use strict';
2-
var assert = require('assert');
2+
var assert = require('power-assert');
33
var React = require('react');
44
var ReactDOM = React; // For 0.13
55
var Router = require('../../index');
@@ -25,7 +25,15 @@ function getRenderedContent() {
2525
}
2626

2727
function assertRendered(text) {
28-
assert.equal(getRenderedContent(), text);
28+
assert.equal(assert._expr(assert._capt(getRenderedContent(), 'arguments/0'), {
29+
content: 'assert.equal(getRenderedContent(), text)',
30+
filepath: 'tests/browser/browser-jsx.jsx',
31+
line: 31
32+
}), assert._expr(assert._capt(text, 'arguments/1'), {
33+
content: 'assert.equal(getRenderedContent(), text)',
34+
filepath: 'tests/browser/browser-jsx.jsx',
35+
line: 31
36+
}));
2937
}
3038

3139
function cleanUp(done) {

tests/browser/browser-jsx.jsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
'use strict';
2-
var assert = require('assert');
2+
var assert = require('power-assert');
33
var React = require('react');
44
var ReactDOM = React; // For 0.13
55
var Router = require('../../index');

tests/browser/browser.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
'use strict';
2-
var assert = require('assert');
2+
var assert = require('power-assert');
33
var React = require('react');
44
var ReactDOM = require('react-dom');
55
var ReactTestUtils = require('react/lib/ReactTestUtils');

0 commit comments

Comments
 (0)