Tests and fixes for QuerystringKeyEnvironment.

Author: andreypopp

lib/environment/QuerystringKeyEnvironment.js

@@ -15,11 +15,7 @@ QuerystringKeyEnvironment.prototype = Object.create(PathnameEnvironment.prototyp
 QuerystringKeyEnvironment.prototype.constructor = QuerystringKeyEnvironment;
 
 QuerystringKeyEnvironment.prototype.getPath = function() {
-  var path = PathnameEnvironment.prototype.getPath.call(this);
-  if (path.indexOf('?') === -1) {
-    return '/';
-  }
-  var query = qs.parse(path.split('?')[1] || '');
+  var query = qs.parse(window.location.search.slice(1));
   return query[this.key] ? '/' + query[this.key] : '/';
 };
 

tests/QueryStringKeyEnvironment.js

@@ -0,0 +1,29 @@
+"use strict";
+
+var assert                    = require('assert');
+var QuerystringKeyEnvironment = require('../lib/environment/QuerystringKeyEnvironment');
+
+describe('QuerystringKeyEnvironment', function() {
+
+  var env;
+
+  beforeEach(function() {
+    env = new QuerystringKeyEnvironment('key');
+  });
+
+  afterEach(function() {
+    window.history.pushState({}, '', '/');
+  });
+
+  it('updates the corresponding key in querystring on setPath', function() {
+    env.setPath('/x', {});
+    assert.equal(location.search, '?key=x');
+  });
+
+  it('returns a corresponding key from querystring via getPath', function() {
+    assert.equal(env.getPath(), '/');
+    window.history.pushState({}, '', '/?key=y');
+    assert.equal(env.getPath(), '/y');
+  });
+
+});