Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Dockerfile permissions and overall build result #68

Closed
2 tasks done
oxcabe opened this issue Oct 27, 2023 · 0 comments · Fixed by #122
Closed
2 tasks done

Review Dockerfile permissions and overall build result #68

oxcabe opened this issue Oct 27, 2023 · 0 comments · Fixed by #122
Assignees
Labels
integration Related to continuous integration and project quality

Comments

@oxcabe
Copy link
Member

oxcabe commented Oct 27, 2023

The Dockerfile seems to produce an image providing a working application. Still, there is some need to ensure that each step is performing as expected, as a good practice.

Tasks:

  • Review all steps from Dockerfile, specially if those are related to filesystem permissions.
  • Fix any unintended effects and, conditionally, add, modify or remove any steps.

When setting up I see the node_modules belonging to the root user still, does this work for you?

Originally posted by @adrianabreu in #65 (comment)

@oxcabe oxcabe added the integration Related to continuous integration and project quality label Oct 27, 2023
@oxcabe oxcabe self-assigned this Oct 27, 2023
oxcabe added a commit that referenced this issue Oct 27, 2023
* Update project dependencies and refactor outdated components (#50)

* Update project dependencies and refactor outdated components (#1)

* Bump production and development dependencies

* Update webpack 'dev' and 'common' config files

* Update i18n and testing implementation

* Update Bootstrap and File Input React types

* Use ES6 modules and restore i18n settings

* Update webpack configuration to handle SCSS files

* Fix Superscalar components hooks and state handling

* Bump Bootstrap deps, fix landing style

* Fix or improve Superscalar machine styles

* Fix VLIW components hooks and state handling

* Fix cycle count not showing in access bars

* Update deploy.yml

* Allow route refresh on development environments (#52)

* Update project dependencies and refactor outdated components (#1)

* Bump production and development dependencies

* Update webpack 'dev' and 'common' config files

* Update i18n and testing implementation

* Update Bootstrap and File Input React types

* Use ES6 modules and restore i18n settings

* Update webpack configuration to handle SCSS files

* Fix Superscalar components hooks and state handling

* Bump Bootstrap deps, fix landing style

* Fix or improve Superscalar machine styles

* Fix VLIW components hooks and state handling

* Fix cycle count not showing in access bars

* Update deploy.yml

* Allow route refreshing on Webpack devServer

* Implement Drag & Drop for VLIW instructions (#54)

* Update project dependencies and refactor outdated components (#1)

* Bump production and development dependencies

* Update webpack 'dev' and 'common' config files

* Update i18n and testing implementation

* Update Bootstrap and File Input React types

* Use ES6 modules and restore i18n settings

* Update webpack configuration to handle SCSS files

* Fix Superscalar components hooks and state handling

* Bump Bootstrap deps, fix landing style

* Fix or improve Superscalar machine styles

* Fix VLIW components hooks and state handling

* Fix cycle count not showing in access bars

* Update deploy.yml

* Install and integrate react-dnd and HTML5 backend modules

* Implement dragging on VLIW code instructions

* Allow route refresh on development environments (#52)

* Implement dropping on VLIW code instructions

* Implement react-file-reader-input locally to avoid dependency errors (#56)

* Remove react-file-reader-input, update deps

* Create FileReaderInput component and update references to it

* Implement FileReaderInput component

* Update project dependencies and refactor outdated components (#1)

* Bump production and development dependencies

* Update webpack 'dev' and 'common' config files

* Update i18n and testing implementation

* Update Bootstrap and File Input React types

* Use ES6 modules and restore i18n settings

* Update webpack configuration to handle SCSS files

* Fix Superscalar components hooks and state handling

* Bump Bootstrap deps, fix landing style

* Fix or improve Superscalar machine styles

* Fix VLIW components hooks and state handling

* Fix cycle count not showing in access bars

* Implement Drag & Drop for VLIW, multiple refactors (#14)

* Allow route refresh on development environments (#52)

* Update project dependencies and refactor outdated components (#1)

* Bump production and development dependencies

* Update webpack 'dev' and 'common' config files

* Update i18n and testing implementation

* Update Bootstrap and File Input React types

* Use ES6 modules and restore i18n settings

* Update webpack configuration to handle SCSS files

* Fix Superscalar components hooks and state handling

* Bump Bootstrap deps, fix landing style

* Fix or improve Superscalar machine styles

* Fix VLIW components hooks and state handling

* Fix cycle count not showing in access bars

* Update deploy.yml

* Allow route refreshing on Webpack devServer

* Implement Drag & Drop for VLIW instructions (#54)

* Update project dependencies and refactor outdated components (#1)

* Bump production and development dependencies

* Update webpack 'dev' and 'common' config files

* Update i18n and testing implementation

* Update Bootstrap and File Input React types

* Use ES6 modules and restore i18n settings

* Update webpack configuration to handle SCSS files

* Fix Superscalar components hooks and state handling

* Bump Bootstrap deps, fix landing style

* Fix or improve Superscalar machine styles

* Fix VLIW components hooks and state handling

* Fix cycle count not showing in access bars

* Update deploy.yml

* Install and integrate react-dnd and HTML5 backend modules

* Implement dragging on VLIW code instructions

* Allow route refresh on development environments (#52)

* Implement dropping on VLIW code instructions

* Implement react-file-reader-input locally to avoid dependency errors (#56)

* Remove react-file-reader-input, update deps

* Create FileReaderInput component and update references to it

* Implement FileReaderInput component

* Fix project build job

* Reintegrate renovate (#15)

* Add renovate.json

* Renovate: Group minor dependencies

* Renovate: Schedule PR on early Mondays

* Implement react-file-reader-input locally to avoid dependency errors (#56)

* Remove react-file-reader-input, update deps

* Create FileReaderInput component and update references to it

* Implement FileReaderInput component

* Remove unused @types/react-file-reader-input

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Pin dependencies (#3)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Fix module generation and testsuite execution (#17)

* Fix dist bundle

* Add "Build and Test" workflow for PRs

* Update package.json

* Update dependency @types/react-dom to v18 (#9)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency multiview to v3 (#10)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency sass-loader to v13 (#12)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency react-redux to v8 (#11)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency style-loader to v3 (#16)

* Update dependency style-loader to v3

* Update dependency @types/react-dom to v18 (#9)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency multiview to v3 (#10)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency sass-loader to v13 (#12)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency react-redux to v8 (#11)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update actions/checkout action to v3 (#4)

* Update actions/checkout action to v3

* Rerun actions

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Óscar Carrasco <[email protected]>

* Update actions/download-artifact action to v3 (#5)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update actions/setup-node action to v3 (#6)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency @types/node to v18 (#18)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency npm to v9 (#24)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency i18next-http-backend to v2 (#23)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency babel-loader to v9 (#20)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency i18next-browser-languagedetector to v7 (#22)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency ava to v5 (#19)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update webpack to v5.78.0

* Update dependency source-map-loader to v4 (#13)

* Update dependency source-map-loader to v4

* Update dependency @types/node to v18 (#18)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency npm to v9 (#24)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency i18next-http-backend to v2 (#23)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency babel-loader to v9 (#20)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency i18next-browser-languagedetector to v7 (#22)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency ava to v5 (#19)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update webpack to v5.78.0

* Update package.json

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Óscar Carrasco <[email protected]>

* Update dependency i18next to v22 (#21)

* Update dependency i18next to v22

* Update dependency ava to v5 (#19)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update webpack to v5.78.0

* Update dependency source-map-loader to v4 (#13)

* Update dependency source-map-loader to v4

* Update dependency @types/node to v18 (#18)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency npm to v9 (#24)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency i18next-http-backend to v2 (#23)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency babel-loader to v9 (#20)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency i18next-browser-languagedetector to v7 (#22)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency ava to v5 (#19)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update webpack to v5.78.0

* Update package.json

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Óscar Carrasco <[email protected]>

* Update i18next and i18next-react to latest

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Óscar Carrasco <[email protected]>

* Update dependency stylelint to v15 (#26)

* Update dependency stylelint to v15

* Update stylelint dependencies to latest

* Update dependency @types/node to v18 (#18)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency npm to v9 (#24)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency i18next-http-backend to v2 (#23)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency babel-loader to v9 (#20)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency i18next-browser-languagedetector to v7 (#22)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency ava to v5 (#19)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update webpack to v5.78.0

* Update dependency source-map-loader to v4 (#13)

* Update dependency source-map-loader to v4

* Update dependency @types/node to v18 (#18)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency npm to v9 (#24)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency i18next-http-backend to v2 (#23)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency babel-loader to v9 (#20)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency i18next-browser-languagedetector to v7 (#22)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency ava to v5 (#19)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update webpack to v5.78.0

* Update package.json

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Óscar Carrasco <[email protected]>

* Update dependency i18next to v22 (#21)

* Update dependency i18next to v22

* Update dependency ava to v5 (#19)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update webpack to v5.78.0

* Update dependency source-map-loader to v4 (#13)

* Update dependency source-map-loader to v4

* Update dependency @types/node to v18 (#18)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency npm to v9 (#24)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency i18next-http-backend to v2 (#23)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency babel-loader to v9 (#20)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency i18next-browser-languagedetector to v7 (#22)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency ava to v5 (#19)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update webpack to v5.78.0

* Update package.json

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Óscar Carrasco <[email protected]>

* Update i18next and i18next-react to latest

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Óscar Carrasco <[email protected]>

* Update stylelint dependencies to latest

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Óscar Carrasco <[email protected]>

* Update dependency webpack-cli to v5 (#30)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency stylelint-config-recommended-scss to v10 (#31)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Manage stale deps and change project description

* Update react-router monorepo to v6 (major) (#33)

* Update react-router monorepo to v6

* Refactor routes after updating react-router to ^6.0.0

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Óscar Carrasco <[email protected]>

* Fix startup runtime errors

* Refactor GitHub Actions, add `release-please` workflow

* feat: empty commit

* chore(main): release 2.1.0 (#34)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* chore(deps): update dependency stylelint-config-standard to v33 (#35)

* chore(deps): update dependency stylelint-config-standard to v33

* Update stylelint to version ^15.5.0

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Óscar Carrasco <[email protected]>

* chore(deps): update all non-major dependencies (#36)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(scripts): rename npm 'start' script to 'dev'

* refactor(docker): improve production build process

* chore(deps): update node.js to v19 (#37)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(webpack): resolve production build issues

* chore(deps): update all non-major dependencies (#40)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update node.js to v20 (#39)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency stylelint-config-recommended-scss to v11 (#42)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency stylelint-scss to v5 (#43)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update all non-major dependencies (#44)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update all non-major dependencies (#46)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* feat(vliw): add memory download action and fix related issues #45

* Added memory download buttons
* More strict VLIW runtime errors check
* Implemented BGT in VLIW
* Use the correct BatchModal for VLIW
* other minor fixes

* refactor(packages): remove coveralls and npm-scripts-info packages

* fix(webpack): set PUBLIC_URL env for production builds

* chore(deps): update all non-major dependencies (#47)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update all non-major dependencies (#48)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(main): release 2.2.0 (#38)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* chore(deps): update dependency stylelint-config-recommended-scss to v12 (#49)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update all non-major dependencies (#50)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update all non-major dependencies (#51)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update all non-major dependencies (#52)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update all non-major dependencies (#56)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(ops): disable build workflow running on main pushes

* chore(deps): update all non-major dependencies (#57)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update all non-major dependencies (#58)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update all non-major dependencies (#60)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update all non-major dependencies (#61)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency stylelint-config-standard to v34 (#59)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update all non-major dependencies (#62)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update all non-major dependencies (#63)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update all non-major dependencies (#64)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update all non-major dependencies (#65)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update all non-major dependencies (#66)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency stylelint-config-recommended-scss to v13 (#69)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency npm to v10 (#68)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update all non-major dependencies (#67)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency typedoc to v0.25.0 (#70)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update all non-major dependencies (#72)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update actions/checkout action to v4 (#71)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update all non-major dependencies (#73)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update all non-major dependencies (#74)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update all non-major dependencies (#75)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update all non-major dependencies (#76)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update all non-major dependencies (#77)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency @types/node to v20 (#81)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update actions/setup-node action to v4 (#80)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update node.js to v21 (#78)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update all non-major dependencies (#79)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: endes0 <[email protected]>
@oxcabe oxcabe linked a pull request Mar 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration Related to continuous integration and project quality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant