Skip to content

Commit 9ff1c39

Browse files
committed
dnn: fixup available backends/targets
1 parent fe459c8 commit 9ff1c39

File tree

3 files changed

+20
-11
lines changed

3 files changed

+20
-11
lines changed

modules/dnn/src/dnn.cpp

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,16 @@ static int PARAM_DNN_BACKEND_DEFAULT = (int)utils::getConfigurationParameterSize
7474
#endif
7575
);
7676

77+
// Additional checks (slowdowns execution!)
78+
static bool DNN_CHECK_NAN_INF = utils::getConfigurationParameterBool("OPENCV_DNN_CHECK_NAN_INF", false);
79+
static bool DNN_CHECK_NAN_INF_DUMP = utils::getConfigurationParameterBool("OPENCV_DNN_CHECK_NAN_INF_DUMP", false);
80+
static bool DNN_CHECK_NAN_INF_RAISE_ERROR = utils::getConfigurationParameterBool("OPENCV_DNN_CHECK_NAN_INF_RAISE_ERROR", false);
81+
82+
using std::vector;
83+
using std::map;
84+
using std::make_pair;
85+
using std::set;
86+
7787
//==================================================================================================
7888

7989
class BackendRegistry
@@ -160,6 +170,9 @@ std::vector< std::pair<Backend, Target> > getAvailableBackends()
160170

161171
std::vector<Target> getAvailableTargets(Backend be)
162172
{
173+
if (be == DNN_BACKEND_DEFAULT)
174+
be = (Backend)PARAM_DNN_BACKEND_DEFAULT;
175+
163176
std::vector<Target> result;
164177
const BackendRegistry::BackendsList all_backends = getAvailableBackends();
165178
for(BackendRegistry::BackendsList::const_iterator i = all_backends.begin(); i != all_backends.end(); ++i )
@@ -172,16 +185,6 @@ std::vector<Target> getAvailableTargets(Backend be)
172185

173186
//==================================================================================================
174187

175-
// Additional checks (slowdowns execution!)
176-
static bool DNN_CHECK_NAN_INF = utils::getConfigurationParameterBool("OPENCV_DNN_CHECK_NAN_INF", false);
177-
static bool DNN_CHECK_NAN_INF_DUMP = utils::getConfigurationParameterBool("OPENCV_DNN_CHECK_NAN_INF_DUMP", false);
178-
static bool DNN_CHECK_NAN_INF_RAISE_ERROR = utils::getConfigurationParameterBool("OPENCV_DNN_CHECK_NAN_INF_RAISE_ERROR", false);
179-
180-
using std::vector;
181-
using std::map;
182-
using std::make_pair;
183-
using std::set;
184-
185188
namespace
186189
{
187190
typedef std::vector<MatShape> ShapesVec;

modules/dnn/test/test_backends.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -292,6 +292,6 @@ TEST_P(DNNTestNetwork, FastNeuralStyle_eccv16)
292292
processNet("dnn/fast_neural_style_eccv16_starry_night.t7", "", inp, "", "", l1, lInf);
293293
}
294294

295-
INSTANTIATE_TEST_CASE_P(/*nothing*/, DNNTestNetwork, dnnBackendsAndTargets());
295+
INSTANTIATE_TEST_CASE_P(/*nothing*/, DNNTestNetwork, dnnBackendsAndTargets(true, true, false));
296296

297297
}} // namespace

modules/dnn/test/test_common.hpp

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -236,8 +236,14 @@ testing::internal::ParamGenerator< tuple<Backend, Target> > dnnBackendsAndTarget
236236
{
237237
available = getAvailableTargets(DNN_BACKEND_OPENCV);
238238
for (std::vector< Target >::const_iterator i = available.begin(); i != available.end(); ++i)
239+
{
240+
if (!withCpuOCV && *i == DNN_TARGET_CPU)
241+
continue;
239242
targets.push_back(make_tuple(DNN_BACKEND_OPENCV, *i));
243+
}
240244
}
245+
if (targets.empty()) // validate at least CPU mode
246+
targets.push_back(make_tuple(DNN_BACKEND_OPENCV, DNN_TARGET_CPU));
241247
return testing::ValuesIn(targets);
242248
}
243249

0 commit comments

Comments
 (0)