Skip to content

Commit b9407f7

Browse files
committed
Fix Python bindings install problem.
1 parent 00565e1 commit b9407f7

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ add_library(${HWS_LIBRARY_NAME} SHARED ${HWS_SOURCES})
2525
add_library(hws::hws ALIAS ${HWS_LIBRARY_NAME})
2626

2727
# set install target
28-
set(HWS_TARGETS_TO_INSTALL ${HWS_LIBRARY_NAME})
28+
set(HWS_TARGETS_TO_INSTALL )
2929

3030
# use C++17
3131
target_compile_features(${HWS_LIBRARY_NAME} PUBLIC cxx_std_17)
@@ -170,7 +170,7 @@ endif ()
170170
########################################################################################################################
171171
include(GNUInstallDirs)
172172
## install all necessary library targets
173-
install(TARGETS ${HWS_TARGETS_TO_INSTALL}
173+
install(TARGETS ${HWS_LIBRARY_NAME}
174174
EXPORT hws_Targets
175175
ARCHIVE DESTINATION "${CMAKE_INSTALL_LIBDIR}" # all files that are neither executables, shared lib or headers
176176
LIBRARY DESTINATION "${CMAKE_INSTALL_LIBDIR}" # all shared lib files

bindings/CMakeLists.txt

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,10 +58,14 @@ endif ()
5858
# create pybind11 module
5959
set(HWS_PYTHON_BINDINGS_LIBRARY_NAME HardwareSampling)
6060
pybind11_add_module(${HWS_PYTHON_BINDINGS_LIBRARY_NAME} ${HWS_PYTHON_BINDINGS_SOURCES})
61-
list(APPEND HWS_TARGETS_TO_INSTALL "${HWS_PYTHON_BINDINGS_LIBRARY_NAME}")
62-
set(HWS_TARGETS_TO_INSTALL "${HWS_TARGETS_TO_INSTALL}" PARENT_SCOPE)
6361

6462
# add necessary compile options
6563
target_include_directories(${HWS_PYTHON_BINDINGS_LIBRARY_NAME} PRIVATE ${CMAKE_CURRENT_LIST_DIR}/..)
6664
target_link_libraries(${HWS_PYTHON_BINDINGS_LIBRARY_NAME} PRIVATE ${HWS_LIBRARY_NAME})
6765
target_compile_definitions(${HWS_PYTHON_BINDINGS_LIBRARY_NAME} PRIVATE PYBIND11_DETAILED_ERROR_MESSAGES)
66+
67+
include(GNUInstallDirs)
68+
# install Python bindings
69+
install(TARGETS ${HWS_PYTHON_BINDINGS_LIBRARY_NAME}
70+
LIBRARY DESTINATION "${CMAKE_INSTALL_LIBDIR}" # all shared lib files
71+
)

0 commit comments

Comments
 (0)