Skip to content

Commit 23baf93

Browse files
committed
fix(ui5-table): stops the propagation of overflow button
Fixes: #11159
1 parent 1d11709 commit 23baf93

File tree

2 files changed

+7
-0
lines changed

2 files changed

+7
-0
lines changed

packages/main/cypress/specs/TableRowActions.cy.tsx

+6
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,10 @@ describe("TableRowActions", () => {
100100
</>
101101
);
102102

103+
cy.get("@table").then($table => {
104+
$table[0].addEventListener("row-click", cy.stub().as("rowClick"));
105+
});
106+
103107
cy.get("@headerRow").shadow().find("#actions-cell").should("exist");
104108
checkTemplateColumn(`${8 + 36 + 4 + 36 + 8}px`);
105109
cy.get("@row1").shadow().find("#actions-cell").children().as("actions");
@@ -166,6 +170,8 @@ describe("TableRowActions", () => {
166170
checkTemplateColumn(`${8 + 36 + 8}px`);
167171
cy.get("@actions").should("have.length", 1);
168172
cy.get("@actions").eq(0).should("have.attr", "icon", "overflow");
173+
174+
cy.get("@rowClick").should("have.callCount", 0);
169175
});
170176

171177
it("tests that invisible actions occupy space for alignment", () => {

packages/main/src/TableRow.ts

+1
Original file line numberDiff line numberDiff line change
@@ -156,6 +156,7 @@ class TableRow extends TableRowBase {
156156
_onOverflowButtonClick(e: MouseEvent) {
157157
const ctor = this.actions[0].constructor as typeof TableRowActionBase;
158158
ctor.showMenu(this._overflowActions, e.target as HTMLElement);
159+
e.stopPropagation();
159160
}
160161

161162
get _isInteractive() {

0 commit comments

Comments
 (0)