Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VariantItem]:[Add support for icon] #6990

Open
1 task done
Mohit83333 opened this issue Feb 24, 2025 · 2 comments
Open
1 task done

[VariantItem]:[Add support for icon] #6990

Mohit83333 opened this issue Feb 24, 2025 · 2 comments

Comments

@Mohit83333
Copy link

Is your feature request related to a problem?

There is requirement to introduce an icon for subcomponent VariantItem which is used as part of component VariantManagement . This icon is needed to differentiate between VariantItems in the popover. As of now the variantItem only accepts string as its children.

For more clarity screenshot is attached in below section.

Describe the solution you'd like

As of now the variantItem only accepts string as its children. if this could be changed to react node or some other feasible solution so that custom data can be added to it.

Image

Describe alternatives you've considered

Expectations are somewhat similar to ListItemCustom - A component to be used as custom list item within the List component. Similarly if there is an option for VariantItemCustom with VariantManagement component which user can provide custom attributes as per requirement.

Additional Context

Required for version 2 and version 1

Organization

SAP

Declaration

  • I’m not disclosing any internal or sensitive information.
@Lukas742
Copy link
Contributor

Lukas742 commented Feb 24, 2025

Hi @Mohit83333

this feature is not covered by our global UX guidelines, so, for this to be implemented the request would need to go through the Inner Source process and be synchronised with the SAP Central Design team first. Please raise a BLI to the central design team and include the ticket number here for reference.

Additional Context

Required for version 2 and version 1

We can only downport bug fixes, not features since this would (i.a.) violate semantic versioning.

Copy link

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Inactive issues will be closed after 7 days. Thanks.

@github-actions github-actions bot added the Stale label Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🆕 New
Development

No branches or pull requests

2 participants