Skip to content

Commit c5c8944

Browse files
matz3matz3
committed
test: Add fixtures to NoDeprecatedApi.js
1 parent 9b83f62 commit c5c8944

File tree

3 files changed

+74
-32
lines changed

3 files changed

+74
-32
lines changed

‎test/fixtures/linter/rules/NoDeprecatedApi/NoDeprecatedApi.js

Lines changed: 20 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
sap.ui.define([
22
"sap/m/Button", "sap/m/DateTimeInput", "sap/base/util/includes", "sap/ui/Device", "sap/ui/core/library", "sap/ui/generic/app/navigation/service/NavigationHandler",
3-
"sap/ui/table/Table", "sap/ui/table/plugins/MultiSelectionPlugin", "sap/ui/core/Configuration", "sap/m/library"
4-
], function(Button, DateTimeInput, includes, Device, coreLib, NavigationHandler, Table, MultiSelectionPlugin, Configuration, mobileLib) {
3+
"sap/ui/table/Table", "sap/ui/table/plugins/MultiSelectionPlugin", "sap/ui/core/Configuration", "sap/m/library",
4+
"sap/m/Input", "sap/m/TileContent", "sap/ui/layout/form/SimpleForm"
5+
], function(Button, DateTimeInput, includes, Device, coreLib, NavigationHandler, Table, MultiSelectionPlugin, Configuration, mobileLib, Input, TileContent, SimpleForm) {
56
"use strict";
67
var dateTimeInput = new DateTimeInput(); // Control is deprecated. A finding only appears for the module dependency, not for the usage.
78

@@ -77,4 +78,21 @@ sap.ui.define([
7778
// (via local function name)
7879
const sapUiXmlView = sap.ui.xmlview;
7980
const view3 = sapUiXmlView("com.ui5.troublesome.app.view.MyView");
81+
82+
const simpleForm = new SimpleForm({
83+
layout: "ResponsiveLayout" // SimpleFormLayout.ResponsiveLayout is deprecated
84+
});
85+
86+
const tileContent = new TileContent({
87+
frameType: "TwoThirds" // FrameType.TwoThirds is deprecated
88+
});
89+
90+
const input = new Input({
91+
type: "Date" // InputType.Date is deprecated
92+
});
93+
94+
// Negative test: ResponsiveGridLayout is not deprecated
95+
const simpleForm2 = new SimpleForm({
96+
layout: "ResponsiveGridLayout" // ResponsiveGridLayout is not deprecated
97+
});
8098
});

‎test/lib/linter/rules/snapshots/NoDeprecatedApi.ts.md

Lines changed: 54 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -1067,7 +1067,7 @@ Generated by [AVA](https://avajs.dev).
10671067
[
10681068
{
10691069
coverageInfo: [],
1070-
errorCount: 33,
1070+
errorCount: 36,
10711071
fatalErrorCount: 0,
10721072
filePath: 'NoDeprecatedApi.js',
10731073
messages: [
@@ -1105,236 +1105,260 @@ Generated by [AVA](https://avajs.dev).
11051105
},
11061106
{
11071107
column: 3,
1108-
line: 9,
1108+
line: 10,
11091109
message: 'Use of deprecated property \'blocked\' of class \'Button\'',
11101110
messageDetails: 'Deprecated test message',
11111111
ruleId: 'no-deprecated-api',
11121112
severity: 2,
11131113
},
11141114
{
11151115
column: 3,
1116-
line: 10,
1116+
line: 11,
11171117
message: 'Use of deprecated property \'tap\' of class \'Button\'',
11181118
messageDetails: 'Deprecated test message',
11191119
ruleId: 'no-deprecated-api',
11201120
severity: 2,
11211121
},
11221122
{
11231123
column: 6,
1124-
line: 13,
1124+
line: 14,
11251125
message: 'Call to deprecated function \'attachTap\' of class \'Button\'',
11261126
messageDetails: 'Deprecated test message',
11271127
ruleId: 'no-deprecated-api',
11281128
severity: 2,
11291129
},
11301130
{
11311131
column: 3,
1132-
line: 18,
1132+
line: 19,
11331133
message: 'Use of deprecated property \'plugins\' of class \'Table\'',
11341134
messageDetails: 'Deprecated test message',
11351135
ruleId: 'no-deprecated-api',
11361136
severity: 2,
11371137
},
11381138
{
11391139
column: 3,
1140-
line: 21,
1140+
line: 22,
11411141
message: 'Use of deprecated property \'groupBy\' of class \'Table\'',
11421142
messageDetails: 'Deprecated test message',
11431143
ruleId: 'no-deprecated-api',
11441144
severity: 2,
11451145
},
11461146
{
11471147
column: 2,
1148-
line: 24,
1148+
line: 25,
11491149
message: 'Call to deprecated function \'includes\'',
11501150
messageDetails: 'Deprecated test message',
11511151
ruleId: 'no-deprecated-api',
11521152
severity: 2,
11531153
},
11541154
{
11551155
column: 2,
1156-
line: 27,
1156+
line: 28,
11571157
message: 'Call to deprecated function \'getIncludesFunction()\'',
11581158
messageDetails: 'Deprecated test message',
11591159
ruleId: 'no-deprecated-api',
11601160
severity: 2,
11611161
},
11621162
{
11631163
column: 16,
1164-
line: 29,
1164+
line: 30,
11651165
message: 'Call to deprecated function \'getCompatibilityVersion\' of class \'Configuration\'',
11661166
messageDetails: 'Deprecated test message',
11671167
ruleId: 'no-deprecated-api',
11681168
severity: 2,
11691169
},
11701170
{
11711171
column: 16,
1172-
line: 30,
1172+
line: 31,
11731173
message: 'Call to deprecated function \'getCompatibilityVersion\' of class \'Configuration\'',
11741174
messageDetails: 'Deprecated test message',
11751175
ruleId: 'no-deprecated-api',
11761176
severity: 2,
11771177
},
11781178
{
11791179
column: 2,
1180-
line: 32,
1180+
line: 33,
11811181
message: 'Use of deprecated property \'webview\' (Device.browser.webview)',
11821182
messageDetails: 'Deprecated test message',
11831183
ruleId: 'no-deprecated-api',
11841184
severity: 2,
11851185
},
11861186
{
11871187
column: 2,
1188-
line: 33,
1188+
line: 34,
11891189
message: 'Use of deprecated property \'webview\'',
11901190
messageDetails: 'Deprecated test message',
11911191
ruleId: 'no-deprecated-api',
11921192
severity: 2,
11931193
},
11941194
{
11951195
column: 2,
1196-
line: 35,
1196+
line: 36,
11971197
message: 'Use of deprecated property \'AnimationMode\' (Configuration.AnimationMode)',
11981198
messageDetails: 'Deprecated test message',
11991199
ruleId: 'no-deprecated-api',
12001200
severity: 2,
12011201
},
12021202
{
12031203
column: 2,
1204-
line: 37,
1204+
line: 38,
12051205
message: 'Use of deprecated property \'MessageType\' (coreLib.MessageType)',
12061206
messageDetails: 'Deprecated test message',
12071207
ruleId: 'no-deprecated-api',
12081208
severity: 2,
12091209
},
12101210
{
12111211
column: 17,
1212-
line: 39,
1212+
line: 40,
12131213
message: 'Use of deprecated API \'MessageType\'',
12141214
messageDetails: 'Deprecated test message',
12151215
ruleId: 'no-deprecated-api',
12161216
severity: 2,
12171217
},
12181218
{
12191219
column: 20,
1220-
line: 43,
1220+
line: 44,
12211221
message: 'Use of deprecated API \'MessageType\'',
12221222
messageDetails: 'Deprecated test message',
12231223
ruleId: 'no-deprecated-api',
12241224
severity: 2,
12251225
},
12261226
{
12271227
column: 2,
1228-
line: 47,
1228+
line: 48,
12291229
message: 'Use of deprecated property \'Date\' (mobileLib.InputType.Date)',
12301230
messageDetails: 'Deprecated test message',
12311231
ruleId: 'no-deprecated-api',
12321232
severity: 2,
12331233
},
12341234
{
12351235
column: 20,
1236-
line: 50,
1236+
line: 51,
12371237
message: 'Call to deprecated function \'storeInnerAppState\' of class \'NavigationHandler\'',
12381238
messageDetails: 'Deprecated test message',
12391239
ruleId: 'no-deprecated-api',
12401240
severity: 2,
12411241
},
12421242
{
12431243
column: 3,
1244-
line: 54,
1244+
line: 55,
12451245
message: 'Use of deprecated property \'blocked\' of class \'Button\'',
12461246
messageDetails: 'Deprecated test message',
12471247
ruleId: 'no-deprecated-api',
12481248
severity: 2,
12491249
},
12501250
{
12511251
column: 3,
1252-
line: 55,
1252+
line: 56,
12531253
message: 'Use of deprecated property \'tap\' of class \'Button\'',
12541254
messageDetails: 'Deprecated test message',
12551255
ruleId: 'no-deprecated-api',
12561256
severity: 2,
12571257
},
12581258
{
12591259
column: 20,
1260-
line: 61,
1260+
line: 62,
12611261
message: 'Access of global variable \'sap\' (sap.ui.xmlfragment)',
12621262
messageDetails: 'Do not use global variables to access UI5 modules or APIs. See Best Practices for Developers (https://ui5.sap.com/#/topic/28fcd55b04654977b63dacbee0552712)',
12631263
ruleId: 'no-globals',
12641264
severity: 2,
12651265
},
12661266
{
12671267
column: 27,
1268-
line: 61,
1268+
line: 62,
12691269
message: 'Call to deprecated function \'xmlfragment\' (sap.ui.xmlfragment)',
12701270
messageDetails: 'Deprecated test message',
12711271
ruleId: 'no-deprecated-api',
12721272
severity: 2,
12731273
},
12741274
{
12751275
column: 20,
1276-
line: 64,
1276+
line: 65,
12771277
message: 'Access of global variable \'sap\' (sap.ui.xmlfragment)',
12781278
messageDetails: 'Do not use global variables to access UI5 modules or APIs. See Best Practices for Developers (https://ui5.sap.com/#/topic/28fcd55b04654977b63dacbee0552712)',
12791279
ruleId: 'no-globals',
12801280
severity: 2,
12811281
},
12821282
{
12831283
column: 27,
1284-
line: 64,
1284+
line: 65,
12851285
message: 'Call to deprecated function \'xmlfragment\' (sap.ui.xmlfragment)',
12861286
messageDetails: 'Deprecated test message',
12871287
ruleId: 'no-deprecated-api',
12881288
severity: 2,
12891289
},
12901290
{
12911291
column: 16,
1292-
line: 69,
1292+
line: 70,
12931293
message: 'Access of global variable \'sap\' (sap.ui.xmlview)',
12941294
messageDetails: 'Do not use global variables to access UI5 modules or APIs. See Best Practices for Developers (https://ui5.sap.com/#/topic/28fcd55b04654977b63dacbee0552712)',
12951295
ruleId: 'no-globals',
12961296
severity: 2,
12971297
},
12981298
{
12991299
column: 23,
1300-
line: 69,
1300+
line: 70,
13011301
message: 'Call to deprecated function \'xmlview\' (sap.ui.xmlview)',
13021302
messageDetails: 'Deprecated test message',
13031303
ruleId: 'no-deprecated-api',
13041304
severity: 2,
13051305
},
13061306
{
13071307
column: 16,
1308-
line: 72,
1308+
line: 73,
13091309
message: 'Access of global variable \'sap\' (sap.ui.xmlview)',
13101310
messageDetails: 'Do not use global variables to access UI5 modules or APIs. See Best Practices for Developers (https://ui5.sap.com/#/topic/28fcd55b04654977b63dacbee0552712)',
13111311
ruleId: 'no-globals',
13121312
severity: 2,
13131313
},
13141314
{
13151315
column: 23,
1316-
line: 72,
1316+
line: 73,
13171317
message: 'Call to deprecated function \'xmlview\' (sap.ui.xmlview)',
13181318
messageDetails: 'Deprecated test message',
13191319
ruleId: 'no-deprecated-api',
13201320
severity: 2,
13211321
},
13221322
{
13231323
column: 23,
1324-
line: 78,
1324+
line: 79,
13251325
message: 'Use of deprecated property \'xmlview\' (sap.ui.xmlview)',
13261326
messageDetails: 'Deprecated test message',
13271327
ruleId: 'no-deprecated-api',
13281328
severity: 2,
13291329
},
13301330
{
13311331
column: 16,
1332-
line: 79,
1332+
line: 80,
13331333
message: 'Call to deprecated function \'sapUiXmlView\' (sap.ui.xmlview)',
13341334
messageDetails: 'Deprecated test message',
13351335
ruleId: 'no-deprecated-api',
13361336
severity: 2,
13371337
},
1338+
{
1339+
column: 3,
1340+
line: 83,
1341+
message: 'Use of deprecated property \'ResponsiveLayout\'',
1342+
messageDetails: 'Deprecated test message',
1343+
ruleId: 'no-deprecated-api',
1344+
severity: 2,
1345+
},
1346+
{
1347+
column: 3,
1348+
line: 87,
1349+
message: 'Use of deprecated property \'TwoThirds\'',
1350+
messageDetails: 'Deprecated test message',
1351+
ruleId: 'no-deprecated-api',
1352+
severity: 2,
1353+
},
1354+
{
1355+
column: 3,
1356+
line: 91,
1357+
message: 'Use of deprecated property \'Date\'',
1358+
messageDetails: 'Deprecated test message',
1359+
ruleId: 'no-deprecated-api',
1360+
severity: 2,
1361+
},
13381362
],
13391363
warningCount: 0,
13401364
},

‎test/lib/linter/rules/snapshots/NoDeprecatedApi.ts.snap

135 Bytes
Binary file not shown.

0 commit comments

Comments
 (0)