Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HGNC search + link to gene symbol #1243

Open
davmlaw opened this issue Jan 29, 2025 · 5 comments
Open

HGNC search + link to gene symbol #1243

davmlaw opened this issue Jan 29, 2025 · 5 comments
Assignees

Comments

@davmlaw
Copy link
Contributor

davmlaw commented Jan 29, 2025

Searching for "HGNC:4171", should go to: /ontology/term/HGNC_4171 like the other ontology terms

On the HGNC page, the link to the name (eg "GATA2" for HGNC:4171) should be a link to the gene symbol page

@davmlaw davmlaw self-assigned this Jan 29, 2025
@davmlaw
Copy link
Contributor Author

davmlaw commented Jan 30, 2025

This was set to admin_only=True by James, as he didn't want Shariant people to search for HGNC and then not see the classifications.

So at the moment, "HGNC:4171" says nothing found for non-admin users.

We could potentially make a setting.HGNC_REDIRECT_TO_GENE_SYMBOL_PAGE, so eg "HGNC:4171" goes to the GATA2 page and shows appropriate classifications. Will run it by Shariant team

@TheMadBug
Copy link
Member

Had a talk to Emma about this, we decide - for an end user point of view:

  • If the user searches for the gene symbol or HGNC id, in all environments, it should go to the gene symbol page. (It going to the Ontology page for the gene symbol has always been a hack that just exposes how things are kept in the database rather than what the user would expect).

  • There should be a link from the gene symbol page to the ontology page. Wont be used much by Shariant users, but will be used by admins. Should still be fine to make this a link for everyone, just with the expectation that Shariant users wont be clicking on it under normal circumstances.

@davmlaw
Copy link
Contributor Author

davmlaw commented Jan 30, 2025

OK, have made it redirect (according to setting, which I've set True in Shariant)

HGNC link from gene page is already covered in SACGF/variantgrid_shariant#130 - Provide link from gene symbol page to HGNC gene symbol

@TheMadBug
Copy link
Member

I don't think we need a setting, I think this should be the default behaviour (unless you can think of an environment where searching for HGNC:XXXX means show me the ontology links for the gene symbol and nothing else)

@davmlaw
Copy link
Contributor Author

davmlaw commented Jan 30, 2025

Removed setting. I kind of wanted it, but yeah it's a developer thing, users would want to go to gene symbol page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants