Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core auth not validating player names #94

Open
S-S-X opened this issue Feb 17, 2023 · 0 comments
Open

Core auth not validating player names #94

S-S-X opened this issue Feb 17, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@S-S-X
Copy link
Owner

S-S-X commented Feb 17, 2023

mineunit/auth.lua

Lines 37 to 42 in 15adf6c

function auth.read(name)
if not entries[name] then
entries[name] = AuthEntry(name)
end
return entries[name]
end

This should validate player name and prevent AuthEntry constructor with invalid player names.

Also AuthEntry should not be called with nonexistent player in first place, make sure that player exists before constructing AuthEntry.
Only construct AuthEntry if player exists (included in mineunit:get_players() table).

@S-S-X S-S-X added the bug Something isn't working label Feb 17, 2023
@S-S-X S-S-X self-assigned this Jan 11, 2024
@S-S-X S-S-X added this to Mineunit Jan 11, 2024
@S-S-X S-S-X moved this to Ready in Mineunit Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Ready
Development

No branches or pull requests

1 participant