-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide numeric biome IDs #91
Comments
Of course, the code the relies on this in Australia mod is disabled and could arguably be deleted because the scraps of functionality that it has as a work in progress seem overlap the biome functionality anyway. But I did think it was worth bringing up in case some other mod uses it. |
I guess this is probably very similar to content ids which is mostly auto increment: Lines 117 to 134 in 15adf6c
(content ids aren't handled exactly like in actual engine, few special core nodes have static ids in minetest but not on mineunit) Biome ID in docs, so I guess something similar to above snippet would work just fine:
edit. Also there's no biome registration in mineunit so would need to add that, probably some stuff as no-ops... |
This is the terminal output when I add the demo test specs to aussieforks/australia
The mod code doesn't load due to a missing C++ API function (
l_get_biome_id
)The builtin Lua code does not manage these numeric IDs, rather they have a C++ getter available as
minetest.get_biome_id
. How should these IDs be provided, some kind of fork to the builtin code to record biome IDs inside Lua so they can be provided later? I'm just not sure where the code would go or I'd bring a PR. I do think it belongs inside mineunit instead of a test fixture.The text was updated successfully, but these errors were encountered: