Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query: Any plans in light of the renaming to Luanti? #103

Open
Montandalar opened this issue Jan 15, 2025 · 1 comment
Open

Query: Any plans in light of the renaming to Luanti? #103

Montandalar opened this issue Jan 15, 2025 · 1 comment
Labels
question Further information is requested

Comments

@Montandalar
Copy link

Since Minetest was renamed Luanti in 5.10.0 of the program, I am interested to know if Mineunit
(a) Plans to change its name at all.
(b) When the documentation files will be updated to refer to the new name
(c) Whether any code changes are needed to support core and whether any refactoring will be done to the program in light of that being the new preferred name for the object that was previously often referred to as minetest (though not in builtin code but most mod code).

Thank you

@S-S-X
Copy link
Owner

S-S-X commented Jan 15, 2025

a)
No, probably wont be renaming Mineunit itself.
I've however renamed some of the minetest usages to core, this however does not have any real effect as those are both exactly same thing under the hood.
Also added Luanti name to the docs, still some work to be done with that..

b)
Some of it last week (not released yet) but few days ago opened PR for those changes too: #102
Wont get rid of Minetest name completely but rather adding it. For Lua namespace however I've planned to fade minetest a bit and increase visibility of core namespace.

c)
core has always worked so that's no really high priority issue, minetest has always been just an alias for core (or other way round, doesn't matter from users perspective).

Mineunit could easily test if minetest or core is actually used in mod code and could easily throw errors based on configuration or based on --engine-version..
...but I think this test would be a lot better suited for Luacheck linter than actual integration/unit test framework.

So probably wont be adding checks like that, instead I could just integrate Luacheck into Mineunit container but not sure that's worth it really and might just complicate things in long run.

@S-S-X S-S-X added the question Further information is requested label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants