Skip to content

x509-cert: support creating Certificate without additional variables #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lumag opened this issue Aug 19, 2022 · 4 comments
Closed

x509-cert: support creating Certificate without additional variables #700

lumag opened this issue Aug 19, 2022 · 4 comments

Comments

@lumag
Copy link
Contributor

lumag commented Aug 19, 2022

x509-cert's Certificate struct can not be easily created in a separate function, as creating it requires several intermediate temporary variables, which are borrowed rather than being moved to the created struct. E.g. my first attempt stopped at borrowing signature, basic_contraint (for Extension's extn_value) and public key DER. I can probably solve the PK part by using newly implemented TryFrom, but for the rest additional work/suggestions would be required. E.g. it would be nice to allow using BitString in addition to BitStringRef for the signature field.

@tarcieri
Copy link
Member

I've definitely been meaning to add a certificate builder type, as it's a blocker for migrating the yubhism crate (which would hopefully free up the x509 crate so we could start using that name).

I might have some time this weekend to look at that.

@lumag
Copy link
Contributor Author

lumag commented Aug 19, 2022

This would be great!

@baloo
Copy link
Member

baloo commented Apr 20, 2023

Could we close this one?

@tarcieri
Copy link
Member

Fixed by #764

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@tarcieri @lumag @baloo and others