ARMv8 Cryptography Extensions support (#250)

Adds a new nightly-only backend which uses ARMv8 Cryptography Extensions
gated under the newly introduced `armv8` crate feature.

Support is provided for AES-128, AES-192, and AES-256, with runtime CPU
feature detection on Linux and macOS targets.

These extensions are supported on both 32-bit and 64-bit ARM targets,
however the current implementation is gated on `aarch64` (as that's
the only architecture it's been tested on so far). However, it could be
easily extended to 32-bit ARMv8 targets as well.

Author: tarcieri

.github/workflows/aes.yml

@@ -36,12 +36,12 @@ jobs:
           target: ${{ matrix.target }}
           profile: minimal
           override: true
-      - run: cargo check --all-features
+      - run: cargo check --features compact,ctr,force-soft
       - run: cargo build --release --target ${{ matrix.target }}
       - run: cargo build --release --target ${{ matrix.target }} --features compact
       - run: cargo build --release --target ${{ matrix.target }} --features ctr
       - run: cargo build --release --target ${{ matrix.target }} --features force-soft
-      - run: cargo build --release --target ${{ matrix.target }} --all-features
+      - run: cargo build --release --target ${{ matrix.target }} --features compact,ctr,force-soft
 
   # Tests for the AES-NI backend
   aesni:
@@ -79,7 +79,6 @@ jobs:
       - run: cargo test --release --target ${{ matrix.target }} --features compact
       - run: cargo test --release --target ${{ matrix.target }} --features ctr
       - run: cargo test --release --target ${{ matrix.target }} --features force-soft
-      - run: cargo test --release --target ${{ matrix.target }} --all-features
 
   # Tests for CPU feature autodetection with fallback to portable software implementation
   autodetect:
@@ -144,7 +143,7 @@ jobs:
       - run: cargo test --release --target ${{ matrix.target }} --features force-soft
       - run: cargo test --release --target ${{ matrix.target }} --features force-soft,compact
       - run: cargo test --release --target ${{ matrix.target }} --features force-soft,ctr
-      - run: cargo test --release --target ${{ matrix.target }} --all-features
+      - run: cargo build --release --target ${{ matrix.target }} --features compact,ctr,force-soft
 
   # Cross-compiled tests
   cross:
@@ -162,7 +161,6 @@ jobs:
             rust: 1.49.0 # MSRV
           - target: powerpc-unknown-linux-gnu
             rust: stable
-
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v1
@@ -178,4 +176,40 @@ jobs:
       - run: cross test --release --target ${{ matrix.target }} --features compact
       - run: cross test --release --target ${{ matrix.target }} --features ctr
       - run: cross test --release --target ${{ matrix.target }} --features force-soft
+      - run: cross test --release --target ${{ matrix.target }} --features compact,ctr,force-soft
+
+  # ARMv8 cross-compiled tests for AES intrinsics (nightly-only)
+  armv8:
+    strategy:
+      matrix:
+        include:
+          - target: aarch64-unknown-linux-gnu
+            rust: nightly
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v1
+      - run: ${{ matrix.deps }}
+      - uses: actions-rs/toolchain@v1
+        with:
+          toolchain: ${{ matrix.rust }}
+          target: ${{ matrix.target }}
+          profile: minimal
+          override: true
+      - run: cargo install cross
+      - run: cross test --release --target ${{ matrix.target }}
+      - run: cross test --release --target ${{ matrix.target }} --features armv8,compact
+      - run: cross test --release --target ${{ matrix.target }} --features armv8,ctr
+      - run: cross test --release --target ${{ matrix.target }} --features armv8,force-soft
       - run: cross test --release --target ${{ matrix.target }} --all-features
+
+  clippy:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v1
+      - uses: actions-rs/toolchain@v1
+        with:
+          toolchain: 1.49.0 # MSRV
+          components: clippy
+          override: true
+          profile: minimal
+      - run: cargo clippy --features compact,ctr,force-soft -- -D warnings

.github/workflows/workspace.yml

@@ -20,7 +20,7 @@ jobs:
         components: clippy
         override: true
         profile: minimal
-    - run: cargo clippy --all --all-features -- -D warnings
+    - run: cargo clippy --all --exclude aes --all-features -- -D warnings
 
   rustfmt:
     runs-on: ubuntu-latest

.gitignore

@@ -1,3 +1 @@
-/target/
-aes/aesni/target/
-aes/aes/target/
+target/

Cargo.lock

@@ -22,12 +22,14 @@ opaque-debug = "0.3"
 
 [dev-dependencies]
 cipher = { version = "0.3", features = ["dev"] }
+hex-literal = "0.2"
 
-[target.'cfg(any(target_arch = "x86_64", target_arch = "x86"))'.dependencies]
-cpufeatures = "0.1"
+[target.'cfg(any(target_arch = "aarch64", target_arch = "x86_64", target_arch = "x86"))'.dependencies]
+cpufeatures = "0.1.4"
 
 [features]
-compact = [] # Reduce code size at the cost of slower performance
+armv8      = [] # Enable ARMv8 AES intrinsics (nightly-only)
+compact    = [] # Reduce code size at the cost of slower performance
 force-soft = [] # Disable support for AES hardware intrinsics
 
 [package.metadata.docs.rs]