-
Notifications
You must be signed in to change notification settings - Fork 451
Make CI disallow leftover debugging code #511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
What about adding an option that will be enabled on CI replacing the definitions of these macros with |
Good idea! It could be gated by a feature or env variable |
How about a checkpatch.pl rule? |
That would trigger on the |
We just need to add (Alternatively I can add a similar lint to klint) |
See #483 (comment)
A CI job could ensure that there are no
dbg!
(orpr_info!
, etc.) calls left in pushed code would be a nice addition to the test suite. I have three high level ideas for how to accomplish this, but I haven't checked the applicability of any of them:disallowed-methods
or so, relatively new) that could potentially be used*.rs
filesWhile the last option is probably simplest, it may not be the cleanest. (note that these are just my first ideas, anyone implementing this can of course diverge from them :D ).
The text was updated successfully, but these errors were encountered: