Skip to content

Commit f5e9a8b

Browse files
authored
Merge pull request #508 from AltF02/module-patch-1
rust: macros: module: remove unnecessary `.clone()`
2 parents 704b2eb + 6afd7a9 commit f5e9a8b

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

rust/macros/module.rs

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -308,9 +308,7 @@ pub fn module(ts: TokenStream) -> TokenStream {
308308

309309
let info = ModuleInfo::parse(&mut it);
310310

311-
let name = info.name.clone();
312-
313-
let mut modinfo = ModInfoBuilder::new(&name);
311+
let mut modinfo = ModInfoBuilder::new(info.name.as_ref());
314312
if let Some(author) = info.author {
315313
modinfo.emit("author", &author);
316314
}
@@ -396,7 +394,7 @@ pub fn module(ts: TokenStream) -> TokenStream {
396394
unsafe {{ <{param_type_internal} as kernel::module_param::ModuleParam>::value(&__{name}_{param_name}_value) }}
397395
}}
398396
",
399-
name = name,
397+
name = info.name,
400398
param_name = param_name,
401399
param_type_internal = param_type_internal,
402400
)
@@ -408,7 +406,7 @@ pub fn module(ts: TokenStream) -> TokenStream {
408406
unsafe {{ <{param_type_internal} as kernel::module_param::ModuleParam>::value(&__{name}_{param_name}_value) }}
409407
}}
410408
",
411-
name = name,
409+
name = info.name,
412410
param_name = param_name,
413411
param_type_internal = param_type_internal,
414412
)
@@ -419,7 +417,7 @@ pub fn module(ts: TokenStream) -> TokenStream {
419417
arg: unsafe {{ &__{name}_{param_name}_value }} as *const _ as *mut kernel::c_types::c_void,
420418
}},
421419
",
422-
name = name,
420+
name = info.name,
423421
param_name = param_name,
424422
);
425423
modinfo.buffer.push_str(
@@ -468,7 +466,7 @@ pub fn module(ts: TokenStream) -> TokenStream {
468466
__bindgen_anon_1: {kparam}
469467
}});
470468
",
471-
name = name,
469+
name = info.name,
472470
param_type_internal = param_type_internal,
473471
read_func = read_func,
474472
param_default = param_default,

0 commit comments

Comments
 (0)