Skip to content

Commit 6f110a5

Browse files
committed
Disable SLUB_TINY for build testing
... and don't error out so hard on missing module descriptions. Before commit 6c6c1fc ("modpost: require a MODULE_DESCRIPTION()") we used to warn about missing module descriptions, but only when building with extra warnigns (ie 'W=1'). After that commit the warning became an unconditional hard error. And it turns out not all modules have been converted despite the claims to the contrary. As reported by Damian Tometzki, the slub KUnit test didn't have a module description, and apparently nobody ever really noticed. The reason nobody noticed seems to be that the slub KUnit tests get disabled by SLUB_TINY, which also ends up disabling a lot of other code, both in tests and in slub itself. And so anybody doing full build tests didn't actually see this failre. So let's disable SLUB_TINY for build-only tests, since it clearly ends up limiting build coverage. Also turn the missing module descriptions error back into a warning, but let's keep it around for non-'W=1' builds. Reported-by: Damian Tometzki <[email protected]> Link: https://lore.kernel.org/all/01070196099fd059-e8463438-7b1b-4ec8-816d-173874be9966-000000@eu-central-1.amazonses.com/ Cc: Masahiro Yamada <[email protected]> Cc: Jeff Johnson <[email protected]> Fixes: 6c6c1fc ("modpost: require a MODULE_DESCRIPTION()") Signed-off-by: Linus Torvalds <[email protected]>
1 parent 16cd1c2 commit 6f110a5

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

mm/Kconfig

+1-1
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ config KVFREE_RCU_BATCHED
201201

202202
config SLUB_TINY
203203
bool "Configure for minimal memory footprint"
204-
depends on EXPERT
204+
depends on EXPERT && !COMPILE_TEST
205205
select SLAB_MERGE_DEFAULT
206206
help
207207
Configures the slab allocator in a way to achieve minimal memory

scripts/mod/modpost.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -1603,7 +1603,7 @@ static void read_symbols(const char *modname)
16031603
}
16041604

16051605
if (!get_modinfo(&info, "description"))
1606-
error("missing MODULE_DESCRIPTION() in %s\n", modname);
1606+
warn("missing MODULE_DESCRIPTION() in %s\n", modname);
16071607
}
16081608

16091609
for (sym = info.symtab_start; sym < info.symtab_stop; sym++) {

0 commit comments

Comments
 (0)