-
Notifications
You must be signed in to change notification settings - Fork 473
Published 0.35.2 does not build on macOS <= 10.15 #1203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
What features are you using? What version of SDL2 are you using? What do you mean by "missing symbols", can you give me an example of the output? There is an issue with |
I'm using Build output: https://github.com/aclysma/rafx/runs/5085580699?check_suite_focus=true
|
Bundled uses the latest version of SDL2, which is probably why it doesn't work with static-link on your system. Try to remove one of the options, or maybe both? |
My point is that a 0.0.x release broke downstream code (this is occurring in CI). If you feel that's ok/expected in this case, the issue can be closed. I'm just suggesting that it may be appropriate to re-release this as 0.36.0 and yank 0.35.2. |
(It's probably caused by this change 29c3915, which also makes some configurations of this project fail in CI) |
I am experiencing similar issue. Looks like Cmake tries to compiler Cocoa SDK code which contains objective C code (at least in my case)?
Maybe this feature should be disable in via SDL2 Cmake? My config:
|
If you can find a way to fix this issue for macOS <= 11, then we can merge it. Otherwise, the issue is a "wontfix" because "bundled" always supports the latest version of SDL2. If github actions have not updated to the latest version of macOS yet that SDL2 needs, it's not an SDL2 issue. There are multiple alternatives for you:
If you can confirm that this issue happens on macOS 12, then it's another story. But even then, I don't personally have a mac so I will need to rely on external help. |
Just a note for anyone wanting to pin version 0.35.1, you need to also pin sdl2-sys. So for example:
Or |
The proper fix for this issue was committed here but is not published: ae41d05 |
Actually see also #1241 This fixed linking errors on an M1 machine running macOS 12.6 but it may be that it is still incompatible with older versions of macOS. |
* enable static linking * install deps needed for static linking * downgrade due to Rust-SDL2/rust-sdl2#1203 * Revert "install deps needed for static linking" This reverts commit 9f147eb.
I just noticed that my CI is flagging missing symbols on macOS that are available starting with macOS 11.0. (for example https://developer.apple.com/documentation/gamecontroller/gchapticslocalityhandles?language=objc)
Is it intended that macOS 10.15 is no longer supported? If so, I think it may be worth considering yanking 0.35.2 and republishing as 0.36. This would avoid downstream crates that previously built ok on macOS 10.15 from also breaking.
The text was updated successfully, but these errors were encountered: