Skip to content

Use references to get the HIR::Literal on HIR::LiteralExpr's #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
philberty opened this issue Sep 30, 2021 · 2 comments · Fixed by #860
Closed

Use references to get the HIR::Literal on HIR::LiteralExpr's #696

philberty opened this issue Sep 30, 2021 · 2 comments · Fixed by #860

Comments

@philberty
Copy link
Member

When we have a data structure containing fields we should use references where possible:

This helper should simply return a reference:

Literal *get_literal () { return &literal; }

To fix this change this helper to return the fat-pointer and fix up the build after that.

@mvvsmk
Copy link
Contributor

mvvsmk commented Jan 15, 2022

Hey, @philberty I was going through the code and you have actually solved this issue in pull request #860 . XD

@philberty philberty self-assigned this Jan 17, 2022
@philberty philberty added this to the Macro Expansion milestone Jan 17, 2022
@philberty philberty linked a pull request Jan 17, 2022 that will close this issue
@philberty
Copy link
Member Author

Thanks, @mvvsmk for pointing that out! Closing this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants