Merge #837

837: HIR::IdentifierPattern had all fields public r=philberty a=philberty

This makes the fields private again and adds the missing getter for the
identifier.


Co-authored-by: Philip Herron <[email protected]>

Author: bors[bot]

gcc/rust/backend/rust-compile-fnparam.h

@@ -48,10 +48,8 @@ class CompileFnParam : public HIRCompileBase
     address_taken_context->lookup_addess_taken (
       param.get_mappings ().get_hirid (), &address_taken);
 
-    compiled_param
-      = ctx->get_backend ()->parameter_variable (fndecl, pattern.variable_ident,
-						 decl_type, address_taken,
-						 locus);
+    compiled_param = ctx->get_backend ()->parameter_variable (
+      fndecl, pattern.get_identifier (), decl_type, address_taken, locus);
   }
 
 private:

gcc/rust/backend/rust-compile-var-decl.h

@@ -59,7 +59,7 @@ class CompileVarDecl : public HIRCompileBase
       translated_type = ctx->get_backend ()->immutable_type (translated_type);
 
     compiled_variable
-      = ctx->get_backend ()->local_variable (fndecl, pattern.variable_ident,
+      = ctx->get_backend ()->local_variable (fndecl, pattern.get_identifier (),
 					     translated_type, NULL /*decl_var*/,
 					     address_taken, locus);
   }

gcc/rust/hir/tree/rust-hir-pattern.h

@@ -68,16 +68,13 @@ class LiteralPattern : public Pattern
 // Identifier pattern HIR node (bind value matched to a variable)
 class IdentifierPattern : public Pattern
 {
-public:
   Identifier variable_ident;
   bool is_ref;
   Mutability mut;
-
-  // bool has_pattern;
   std::unique_ptr<Pattern> to_bind;
-
   Location locus;
 
+public:
   std::string as_string () const override;
 
   // Returns whether the IdentifierPattern has a pattern to bind.
@@ -126,6 +123,8 @@ class IdentifierPattern : public Pattern
 
   void accept_vis (HIRVisitor &vis) override;
 
+  Identifier get_identifier () const { return variable_ident; }
+
 protected:
   /* Use covariance to implement clone function as returning this object rather
    * than base */