Remove iterate_params from AST::CallExpr and AST::MethodCallExpr

These lambda iterators are removed because they make working
with IR more complex. Instead, we are using the get_params ()
to access the parameters with the help of a for loop.

Fixes #722 #723

Signed-off-by: Nirmal Patel <[email protected]>

Author: nirmal-j-patel

gcc/rust/ast/rust-expr.h

@@ -1916,15 +1916,6 @@ class CallExpr : public ExprWithoutBlock
   void mark_for_strip () override { function = nullptr; }
   bool is_marked_for_strip () const override { return function == nullptr; }
 
-  void iterate_params (std::function<bool (Expr *)> cb)
-  {
-    for (auto &param : params)
-      {
-	if (!cb (param.get ()))
-	  return;
-      }
-  }
-
   // TODO: this mutable getter seems really dodgy. Think up better way.
   const std::vector<std::unique_ptr<Expr> > &get_params () const
   {
@@ -2025,15 +2016,6 @@ class MethodCallExpr : public ExprWithoutBlock
   void mark_for_strip () override { receiver = nullptr; }
   bool is_marked_for_strip () const override { return receiver == nullptr; }
 
-  void iterate_params (std::function<bool (Expr *)> cb)
-  {
-    for (auto &param : params)
-      {
-	if (!cb (param.get ()))
-	  return;
-      }
-  }
-
   // TODO: this mutable getter seems really dodgy. Think up better way.
   const std::vector<std::unique_ptr<Expr> > &get_params () const
   {

gcc/rust/hir/rust-ast-lower-expr.h

@@ -192,12 +192,14 @@ class ASTLoweringExpr : public ASTLoweringBase
   {
     HIR::Expr *func
       = ASTLoweringExpr::translate (expr.get_function_expr ().get ());
+
+    auto const &in_params = expr.get_params ();
     std::vector<std::unique_ptr<HIR::Expr> > params;
-    expr.iterate_params ([&] (AST::Expr *p) mutable -> bool {
-      auto trans = ASTLoweringExpr::translate (p);
-      params.push_back (std::unique_ptr<HIR::Expr> (trans));
-      return true;
-    });
+    for (auto &param : in_params)
+      {
+	auto trans = ASTLoweringExpr::translate (param.get ());
+	params.push_back (std::unique_ptr<HIR::Expr> (trans));
+      }
 
     auto crate_num = mappings->get_current_crate ();
     Analysis::NodeMapping mapping (
@@ -217,12 +219,13 @@ class ASTLoweringExpr : public ASTLoweringBase
     HIR::Expr *receiver
       = ASTLoweringExpr::translate (expr.get_receiver_expr ().get ());
 
+    auto const &in_params = expr.get_params ();
     std::vector<std::unique_ptr<HIR::Expr> > params;
-    expr.iterate_params ([&] (AST::Expr *p) mutable -> bool {
-      auto trans = ASTLoweringExpr::translate (p);
-      params.push_back (std::unique_ptr<HIR::Expr> (trans));
-      return true;
-    });
+    for (auto &param : in_params)
+      {
+	auto trans = ASTLoweringExpr::translate (param.get ());
+	params.push_back (std::unique_ptr<HIR::Expr> (trans));
+      }
 
     auto crate_num = mappings->get_current_crate ();
     Analysis::NodeMapping mapping (crate_num, expr.get_node_id (),

gcc/rust/resolve/rust-ast-resolve-expr.h

@@ -101,10 +101,9 @@ class ResolveExpr : public ResolverBase
   void visit (AST::CallExpr &expr) override
   {
     ResolveExpr::go (expr.get_function_expr ().get (), expr.get_node_id ());
-    expr.iterate_params ([&] (AST::Expr *p) mutable -> bool {
-      ResolveExpr::go (p, expr.get_node_id ());
-      return true;
-    });
+    auto const &in_params = expr.get_params ();
+    for (auto &param : in_params)
+      ResolveExpr::go (param.get (), expr.get_node_id ());
   }
 
   void visit (AST::MethodCallExpr &expr) override
@@ -117,10 +116,9 @@ class ResolveExpr : public ResolverBase
 	ResolveTypeToCanonicalPath::type_resolve_generic_args (args);
       }
 
-    expr.iterate_params ([&] (AST::Expr *p) mutable -> bool {
-      ResolveExpr::go (p, expr.get_node_id ());
-      return true;
-    });
+    auto const &in_params = expr.get_params ();
+    for (auto &param : in_params)
+      ResolveExpr::go (param.get (), expr.get_node_id ());
   }
 
   void visit (AST::AssignmentExpr &expr) override