Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source for xml-decorators version 1.0.8 - fix for linter errors #13

Open
bhofner opened this issue Sep 23, 2020 · 0 comments
Open

source for xml-decorators version 1.0.8 - fix for linter errors #13

bhofner opened this issue Sep 23, 2020 · 0 comments

Comments

@bhofner
Copy link

bhofner commented Sep 23, 2020

Hi,

When I pull the package from npm, I get the version 1.0.8.
What I find here is the package 1.0.6.
Have you moved to a different repository?

The npm version 1.0.8 has some issues that could be fixed with the following patches (assuming native Promises are enough):

/node_modules/xml-decorators/lib/models/XMLChild.ts

71c71
<             let nsSchema = {};
---
>             let nsSchema: any = {};
169c169
<     let attributes = {};
---
>     let attributes: any = {};

/node_modules/xml-decorators/lib/models/XMLElement.ts

2c2
< import * as Promise from "bluebird";
---
> // import * as Promise from "bluebird";
19,20c19,20
<   private attributes: XMLAttribute[];
<   private children: XMLChild[];
---
>   private attributes?: XMLAttribute[];
>   private children?: XMLChild[];

Could you please publish a patched version in npm or provide me with the up-to-date source so that I can patch my local version of the package?

Best regards, Bernd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant