Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working with Node 10 #15

Open
Fumler opened this issue Jun 11, 2018 · 0 comments
Open

Not working with Node 10 #15

Fumler opened this issue Jun 11, 2018 · 0 comments

Comments

@Fumler
Copy link

Fumler commented Jun 11, 2018

Hello. Thank you for creating this package, it has been a big help for us. Been using this (in prod 😅) for a while.

After we updated to Node 10 it stopped working for outgoing requests, the express module still works, but httpClient does not.

  opentracing-auto:instrumentation:httpClient Patched +0ms
  opentracing-auto:instrument Instrumentation "httpClient" applied on module "http" { moduleVersion: undefined, supportedVersions: undefined } +53ms
  opentracing-auto:instrument Instrumentation "express" applied on module "express" { moduleVersion: '4.16.3', supportedVersions: [ '4.x' ] } +127ms
  opentracing-auto:instrumentation:expressError Patched +0ms
  opentracing-auto:instrument Instrumentation "expressError" applied on module "express" { moduleVersion: '4.16.3', supportedVersions: [ '4.x' ] } +1ms

And then when we get incoming requests:

opentracing-auto:cls Root span started +0ms
  opentracing-auto:instrumentation:express Operation started http_server { 'http.url': 'http://localhost:4000/', 'http.method': 'GET' } +33s

But on outgoing requests we get no logs of httpClient doing anything.

Any ideas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant