Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.19.2/1.21.1] Deposits can't accept Max Y Value below 0. #224

Open
Kanzaji opened this issue Jan 12, 2025 · 0 comments
Open

[1.19.2/1.21.1] Deposits can't accept Max Y Value below 0. #224

Kanzaji opened this issue Jan 12, 2025 · 0 comments
Assignees
Labels
bug Something isn't working to be reviewed requires additional analysis

Comments

@Kanzaji
Copy link
Contributor

Kanzaji commented Jan 12, 2025

Issue description

https://github.com/Ridanisaurus/EmendatusEnigmatica/blob/EEV2-1.19/src/main/java/com/ridanisaurus/emendatusenigmatica/world/gen/feature/SphereOreFeature.java#L67

Random method doesn't accept negative values as an input, causing a crash on generation.

Steps to reproduce

  1. Set Y Max value in a deposit to a negative value.
  2. Set a chance high (For easier reproduction)
  3. Create a world.

Minecraft version

1.19.2 (Latest)

Forge version

Doesn't affect the result.

Emendatus Enigmatica version

Current Dev Branch (Manually Compiled)

Other relevant versions

No response

If a (crash)log is relevant for this issue, link it here: (It's almost always relevant)

https://canary.discord.com/channels/1108377598427406396/1108377599501152300/1327813862946508840

@Kanzaji Kanzaji added bug Something isn't working to be reviewed requires additional analysis labels Jan 12, 2025
@Kanzaji Kanzaji moved this to Bugs in Port to 1.21 Jan 12, 2025
@Kanzaji Kanzaji moved this from Bugs to In Progress in Port to 1.21 Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working to be reviewed requires additional analysis
Projects
None yet
Development

No branches or pull requests

2 participants