replace erase() with clear() to make imported keylist deconstruction faster

DarrenJiang13 · DarrenJiang13 · commit efcaa4e34f37 · 2024-01-19T10:42:22.000+08:00
diff --git a/obj_gen.cpp b/obj_gen.cpp
@@ -529,10 +529,10 @@ imported_keylist::imported_keylist(const char *filename)
 
 imported_keylist::~imported_keylist()
 {
-    while (!m_keys.empty()) {
-        free(m_keys.front());
-        m_keys.erase(m_keys.begin());
+    for (unsigned int i = 0; i < m_keys.size(); i++) {
+        free(m_keys[i]);
     }
+    m_keys.clear();
 }
 
 bool imported_keylist::read_keys(void)

Original file line number	Diff line number	Diff line change
`@@ -529,10 +529,10 @@ imported_keylist::imported_keylist(const char *filename)`
`529`	`529`
`530`	`530`	`imported_keylist::~imported_keylist()`
`531`	`531`	`{`
`532`		`- while (!m_keys.empty()) {`
`533`		`- free(m_keys.front());`
`534`		`- m_keys.erase(m_keys.begin());`
	`532`	`+ for (unsigned int i = 0; i < m_keys.size(); i++) {`
	`533`	`+ free(m_keys[i]);`
`535`	`534`	`}`
	`535`	`+ m_keys.clear();`
`536`	`536`	`}`
`537`	`537`
`538`	`538`	`bool imported_keylist::read_keys(void)`