Fix property keys invalidation on accessing new entities (#7)

Author: jeffreylovitz

lib/redisgraph.rb

@@ -23,7 +23,7 @@ def initialize(opts = {})
     end
 
     def invalidate
-      @labels = @property_key = @relationship_types
+      @labels = @property_keys = @relationship_types = nil
     end
 
     def labels
@@ -57,7 +57,7 @@ def initialize(graph, redis_options = {})
 
   # Execute a command and return its parsed result
   def query(command)
-    resp = @connection.call("GRAPH.QUERY", @graphname, command, '--compact')
+    resp = @connection.call('GRAPH.QUERY', @graphname, command, '--compact')
     QueryResult.new(resp,
                     metadata:   @metadata)
   rescue Redis::CommandError => e
@@ -66,14 +66,14 @@ def query(command)
 
   # Return the execution plan for a given command
   def explain(command)
-    @connection.call("GRAPH.EXPLAIN", @graphname, command)
+    @connection.call('GRAPH.EXPLAIN', @graphname, command)
   rescue Redis::CommandError => e
     raise ExplainError, e
   end
 
   # Delete the graph and all associated keys
   def delete
-    @connection.call("GRAPH.DELETE", @graphname)
+    @connection.call('GRAPH.DELETE', @graphname)
   rescue Redis::CommandError => e
     raise DeleteError, e
   end

lib/redisgraph/query_result.rb

@@ -1,3 +1,19 @@
+# frozen_string_literal: true
+
+# Data types that can be returned in result sets
+module ValueType
+  UNKNOWN = 0
+  NULL = 1
+  STRING = 2
+  INTEGER = 3
+  BOOLEAN = 4
+  DOUBLE = 5
+  ARRAY = 6
+  EDGE = 7
+  NODE = 8
+  PATH = 9 # TODO: not yet implemented
+end
+
 class QueryResult
   attr_accessor :columns
   attr_accessor :resultset
@@ -21,6 +37,8 @@ def initialize(response, opts = {})
   end
 
   def print_resultset
+    return unless columns
+
     pretty = Terminal::Table.new headings: columns do |t|
       resultset.each { |record| t << record }
     end
@@ -33,7 +51,6 @@ def parse_resultset(response)
 
     # Any non-empty result set will have multiple rows (arrays)
 
-
     # First row is header describing the returned records, corresponding
     # precisely in order and naming to the RETURN clause of the query.
     header = response[0]
@@ -47,19 +64,7 @@ def parse_resultset(response)
       header.reduce([]) do |agg, (type, _it)|
         i += 1
         el = row[i]
-
-        case type
-        when 1 # scalar
-          agg << map_scalar(el[0], el[1])
-        when 2 # node
-          props = el[2]
-          agg << props.sort_by { |prop| prop[0] }.map { |prop| map_prop(prop) }
-        when 3 # relation
-          props = el[4]
-          agg << props.sort_by { |prop| prop[0] }.map { |prop| map_prop(prop) }
-        end
-
-        agg
+        agg << map_scalar(el[0], el[1])
       end
     end
 
@@ -68,25 +73,23 @@ def parse_resultset(response)
 
   def map_scalar(type, val)
     map_func = case type
-               when 1 # null
+               when ValueType::NULL
                  return nil
-               when 2 # string
+               when ValueType::STRING
                  :to_s
-               when 3 # integer
+               when ValueType::INTEGER
                  :to_i
-               when 4 # boolean
+               when ValueType::BOOLEAN
                  # no :to_b
-                 return val == "true"
-               when 5 # double
+                 return val == 'true'
+               when ValueType::DOUBLE
                  :to_f
-               # TODO: when in the distro packages and docker images,
-               #   the following _should_ work
-               # when 6 # array
-               #   val.map { |it| map_scalar(it[0], it[1]) }
-               when 7 # relation
+               when ValueType::ARRAY
+                 return val.map { |it| map_scalar(it[0], it[1]) }
+               when ValueType::EDGE
                  props = val[4]
                  return props.sort_by { |prop| prop[0] }.map { |prop| map_prop(prop) }
-               when 8 # node
+               when ValueType::NODE
                  props = val[2]
                  return props.sort_by { |prop| prop[0] }.map { |prop| map_prop(prop) }
                end
@@ -98,7 +101,7 @@ def map_prop(prop)
 
     property_keys = @metadata.property_keys
     prop_index = prop[0]
-    if prop_index > property_keys.length
+    if prop_index >= property_keys.length
       @metadata.invalidate
       property_keys = @metadata.property_keys
     end